starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9056] [MERGED] Fix CommandPalette to prefer inner interactions over bindings #27404

New Issue
Open
opened 2026-01-31 09:21:46 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:21:46 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9056
Author: @Don-Vito
Created: 2/5/2021
Status: ✅ Merged
Merged: 2/10/2021
Merged by: @DHowett

Base: main ← Head: 9044-prefer-palette-keys

📝 Commits (4)

  • 54c2060 Fix CommandPalette to prefer inner interactions over bindings
  • 20e2682 Merge remote-tracking branch 'upstream/main' into 9044-prefer-palette-keys
  • 698aa10 Fix line endings
  • f6ada94 Merge remote-tracking branch 'upstream/main' into 9044-prefer-palette-keys

📊 Changes

3 files changed (+41 additions, -59 deletions)

View changed files

📝 src/cascadia/TerminalApp/CommandPalette.cpp (+25 -40)
📝 src/cascadia/TerminalApp/CommandPalette.h (+1 -2)
📝 src/cascadia/TerminalApp/CommandPalette.xaml (+15 -17)

📄 Description

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Currently TerminalPage registers on CmdPal key events:
    • To invoke bindings when the palette is open
    • Since some key combinations are not triggered by KeyDown
      it registers for PreviewKeyDown
  • As a result bindings might be preferred over navigation
    (e.g., ctrl+v will paste into Terminal rather than into search box)
  • To fix this, I moved all interactions inside the CmdPal into
    PreviewKeyDown as well
  • In addition, added specific handling for copy/paste
    which now allow to interact with search box even if not focused

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9056 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 2/5/2021 **Status:** ✅ Merged **Merged:** 2/10/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `9044-prefer-palette-keys` --- ### 📝 Commits (4) - [`54c2060`](https://github.com/microsoft/terminal/commit/54c2060e7aba2aa8b4624afd5cc9934aca9e0792) Fix CommandPalette to prefer inner interactions over bindings - [`20e2682`](https://github.com/microsoft/terminal/commit/20e26822f9bda5f03efa54ee3e4a26188f843f60) Merge remote-tracking branch 'upstream/main' into 9044-prefer-palette-keys - [`698aa10`](https://github.com/microsoft/terminal/commit/698aa10c25d906451e8237349dda961f71c79b44) Fix line endings - [`f6ada94`](https://github.com/microsoft/terminal/commit/f6ada941fd78408b75efbf19b1b4458301717d04) Merge remote-tracking branch 'upstream/main' into 9044-prefer-palette-keys ### 📊 Changes **3 files changed** (+41 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CommandPalette.cpp` (+25 -40) 📝 `src/cascadia/TerminalApp/CommandPalette.h` (+1 -2) 📝 `src/cascadia/TerminalApp/CommandPalette.xaml` (+15 -17) </details> ### 📄 Description ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/issues/9044 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments * Currently TerminalPage registers on CmdPal key events: * To invoke bindings when the palette is open * Since some key combinations are not triggered by KeyDown it registers for PreviewKeyDown * As a result bindings might be preferred over navigation (e.g., ctrl+v will paste into Terminal rather than into search box) * To fix this, I moved all interactions inside the CmdPal into PreviewKeyDown as well * In addition, added specific handling for copy/paste which now allow to interact with search box even if not focused --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:46 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27404
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?