[PR #9078] [MERGED] Quickly fix a mistake in #8602 #27411

Open
opened 2026-01-31 09:21:49 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9078
Author: @PankajBhojwani
Created: 2/8/2021
Status: Merged
Merged: 2/9/2021
Merged by: @DHowett

Base: mainHead: dev/pabhoj/settings_fix


📝 Commits (1)

📊 Changes

2 files changed (+2 additions, -3 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalSettings.cpp (+2 -0)
📝 src/cascadia/TerminalApp/TerminalSettings.h (+0 -3)

📄 Description

Summary of the Pull Request

There was a mistake in #8602, this change fixes that (using and include moved to cpp file)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9078 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 2/8/2021 **Status:** ✅ Merged **Merged:** 2/9/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/pabhoj/settings_fix` --- ### 📝 Commits (1) - [`33327b5`](https://github.com/microsoft/terminal/commit/33327b53e6bc3703927518309f0045d3ad4f7943) fix ### 📊 Changes **2 files changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalSettings.cpp` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalSettings.h` (+0 -3) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request There was a mistake in #8602, this change fixes that (`using` and `include` moved to cpp file) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:49 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27411