[PR #9107] [MERGED] Prevent read-only warning on mouse move, wheel and release #27423

Open
opened 2026-01-31 09:21:53 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9107
Author: @Don-Vito
Created: 2/10/2021
Status: ✅ Merged
Merged: 2/11/2021
Merged by: @undefined

Base: main ← Head: 9074-no-readonly-dialog-onmouse


📝 Commits (1)

  • f398d4d Prevent read-only warning on mouse move and wheel

📊 Changes

1 file changed (+8 additions, -3 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+8 -3)

📄 Description

Avoid sending mouse move / wheel / release to Terminal in the first place.
This kind of short-circuiting will prevent us reaching the
attempt to send input to connection
(that could result in the warning dialog in the read-only mode)

Closes #9074


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9107 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 2/10/2021 **Status:** ✅ Merged **Merged:** 2/11/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `9074-no-readonly-dialog-onmouse` --- ### 📝 Commits (1) - [`f398d4d`](https://github.com/microsoft/terminal/commit/f398d4d993a83aed34f700d9e557fbc86a386316) Prevent read-only warning on mouse move and wheel ### 📊 Changes **1 file changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+8 -3) </details> ### 📄 Description Avoid sending mouse move / wheel / release to Terminal in the first place. This kind of short-circuiting will prevent us reaching the attempt to send input to connection (that could result in the warning dialog in the read-only mode) Closes #9074 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:53 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27423