[PR #9126] [MERGED] Perform polish of miscellaneous Settings UI bugs #27432

Open
opened 2026-01-31 09:21:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9126
Author: @carlos-zamora
Created: 2/11/2021
Status: Merged
Merged: 2/17/2021
Merged by: @undefined

Base: mainHead: dev/cazamor/sui/style-polish


📝 Commits (5)

  • 0b0dbdf Make buttons center-vertically aligned
  • 0288f06 Fix focus on CS rename keyboard interaction
  • d5ef552 Force tab navigation to cycle on navigation view
  • a613b08 Add automation properties to SettingsNav
  • bc9eb09 Merge branch 'main' into dev/cazamor/sui/style-polish

📊 Changes

5 files changed (+14 additions, -3 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.cpp (+3 -0)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/CommonResources.xaml (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+4 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.xaml (+5 -2)

📄 Description


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9126 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 2/11/2021 **Status:** ✅ Merged **Merged:** 2/17/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/sui/style-polish` --- ### 📝 Commits (5) - [`0b0dbdf`](https://github.com/microsoft/terminal/commit/0b0dbdfa03bb2eee50606a759d812d5c5d71df84) Make buttons center-vertically aligned - [`0288f06`](https://github.com/microsoft/terminal/commit/0288f06d57dbab49af0cb833343f6143daba0c6d) Fix focus on CS rename keyboard interaction - [`d5ef552`](https://github.com/microsoft/terminal/commit/d5ef5525564ef2cea766c93cc4fe7cb484b5832c) Force tab navigation to cycle on navigation view - [`a613b08`](https://github.com/microsoft/terminal/commit/a613b08b1216a47c0f010a2703356d8ca29289e7) Add automation properties to SettingsNav - [`bc9eb09`](https://github.com/microsoft/terminal/commit/bc9eb0977d6ba2bbfcb3278bb722e94bd8c5e890) Merge branch 'main' into dev/cazamor/sui/style-polish ### 📊 Changes **5 files changed** (+14 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.cpp` (+3 -0) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/CommonResources.xaml` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+4 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.xaml` (+5 -2) </details> ### 📄 Description - 0b0dbdf Makes the browse buttons center vertically aligned - This is now made possible by #8919. The "center" used to include the height of the header. Now that it's separated, the center is solely calculated to be the text box. - Closes #8764 - 0288f06 Fix keyboard navigation focus for color schemes rename button - Enter/Esc when in the scheme renamer now focuses the combo box - Keyboard-invoking accept/cancel button focuses the rename button - References #8765 and #8768 - d5ef552 Cyclical tab navigation - now, if you try to tab past the save button, you cycle back to the beginning of the navigation view - this is consistent with the xaml controls gallery - References #8768 - a613b08 AutomationProperties for Save, Reset, and open json buttons - References #8899 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:21:56 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27432