[PR #9228] [CLOSED] Allow regex search #27484

Open
opened 2026-01-31 09:22:14 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9228
Author: @PankajBhojwani
Created: 2/20/2021
Status: Closed

Base: mainHead: dev/pabhoj/regex_search


📝 Commits (10+)

📊 Changes

36 files changed (+1913 additions, -481686 deletions)

View changed files

.github/actions/spelling/README.md (+15 -0)
.github/actions/spelling/advice.md (+48 -0)
.github/actions/spelling/advice.txt (+0 -27)
📝 .github/actions/spelling/allow/README.md (+3 -3)
.github/actions/spelling/allow/allow.txt (+108 -0)
.github/actions/spelling/allow/apis.txt (+248 -0)
📝 .github/actions/spelling/allow/chinese.txt (+0 -0)
.github/actions/spelling/allow/colors.txt (+117 -0)
📝 .github/actions/spelling/allow/fonts.txt (+1 -0)
📝 .github/actions/spelling/allow/japanese.txt (+0 -0)
.github/actions/spelling/allow/math.txt (+11 -0)
📝 .github/actions/spelling/allow/microsoft.txt (+34 -0)
📝 .github/actions/spelling/allow/names.txt (+16 -1)
.github/actions/spelling/candidate.patterns (+523 -0)
.github/actions/spelling/dictionary/apis.txt (+0 -107)
.github/actions/spelling/dictionary/colors.txt (+0 -782)
.github/actions/spelling/dictionary/dictionary.txt (+0 -479849)
.github/actions/spelling/dictionary/math.txt (+0 -3)
📝 .github/actions/spelling/excludes.txt (+59 -8)
📝 .github/actions/spelling/expect/alphabet.txt (+14 -7)

...and 16 more files

📄 Description

Summary of the Pull Request

Initial stage of implementing regex search

Todos left:

  • Allow find previous
  • Wraparound when search fails
  • Change the icon in the search box

References

#3920

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9228 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 2/20/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/pabhoj/regex_search` --- ### 📝 Commits (10+) - [`dfa8164`](https://github.com/microsoft/terminal/commit/dfa8164750ae58bd054ffd1ef6259dd1ce3e5596) initial - [`65fba1d`](https://github.com/microsoft/terminal/commit/65fba1dd8cc0dc1b714078e6caaaae9ee9374013) wrap around - [`f7c47a0`](https://github.com/microsoft/terminal/commit/f7c47a070718a0a2e99e1cfbc3ae79442493ba9a) find previous - [`71b83da`](https://github.com/microsoft/terminal/commit/71b83dac8eec3257975efe0f76c220eb76ad989a) comment - [`08f5843`](https://github.com/microsoft/terminal/commit/08f5843e61437e828cc99b5cedb45b71ff84ea82) update comment - [`09fa066`](https://github.com/microsoft/terminal/commit/09fa0660c3d1bb1bdc5c4439e21f769e930e6b28) take into account glyph width - [`12b5f65`](https://github.com/microsoft/terminal/commit/12b5f65ab8f5512f70c99817bff8a7d77f441ca4) const - [`839af9f`](https://github.com/microsoft/terminal/commit/839af9fe96dfc0f3dbe6a322b7a9626ae9ea348f) move increment to inside the loop - [`324a6a3`](https://github.com/microsoft/terminal/commit/324a6a3f520832b942b7809d4966a3c0d55137e3) fix test hopefully? - [`0d6631e`](https://github.com/microsoft/terminal/commit/0d6631e7dfcadf000fd95139f2eb31fa35db0440) Migrate spelling-0.0.19 changes from main ### 📊 Changes **36 files changed** (+1913 additions, -481686 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/spelling/README.md` (+15 -0) ➕ `.github/actions/spelling/advice.md` (+48 -0) ➖ `.github/actions/spelling/advice.txt` (+0 -27) 📝 `.github/actions/spelling/allow/README.md` (+3 -3) ➕ `.github/actions/spelling/allow/allow.txt` (+108 -0) ➕ `.github/actions/spelling/allow/apis.txt` (+248 -0) 📝 `.github/actions/spelling/allow/chinese.txt` (+0 -0) ➕ `.github/actions/spelling/allow/colors.txt` (+117 -0) 📝 `.github/actions/spelling/allow/fonts.txt` (+1 -0) 📝 `.github/actions/spelling/allow/japanese.txt` (+0 -0) ➕ `.github/actions/spelling/allow/math.txt` (+11 -0) 📝 `.github/actions/spelling/allow/microsoft.txt` (+34 -0) 📝 `.github/actions/spelling/allow/names.txt` (+16 -1) ➕ `.github/actions/spelling/candidate.patterns` (+523 -0) ➖ `.github/actions/spelling/dictionary/apis.txt` (+0 -107) ➖ `.github/actions/spelling/dictionary/colors.txt` (+0 -782) ➖ `.github/actions/spelling/dictionary/dictionary.txt` (+0 -479849) ➖ `.github/actions/spelling/dictionary/math.txt` (+0 -3) 📝 `.github/actions/spelling/excludes.txt` (+59 -8) 📝 `.github/actions/spelling/expect/alphabet.txt` (+14 -7) _...and 16 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Initial stage of implementing regex search Todos left: * [x] Allow find previous * [x] Wraparound when search fails * [ ] Change the icon in the search box <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #3920 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:14 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27484