starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9226] res: prepend XML line to SVG files, to pass strict svg checks #27487

New Issue
Open
opened 2026-01-31 09:22:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:22:14 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/9226

State: closed
Merged: Yes

A header line is missing from a few .svg files, denying their use (via
a security error) in WordPress (if svg support is enabled). The upload
is rejected even though the web browser could display the image if it
were dragged into its own tab.

The .svg images appear to have been edited at different times and with
different tools. Their contents are in a different style. Two of them
are beautiful and the rest do not follow suit and do not function the
same.

I don't know enough to make them all the same style, but changes can be
made to three of them to make them work the way I was expecting (see
below).

Validation Steps Performed

  • Perform the change with a text editor
  • Open a new WordPress post page
  • Drag-and-drop the changed file into that WordPress edit box
  • (The WordPress media upload dialog appears and the file is uploaded)
  • Confirmed that the file does not trigger a "security error" (as seen
    at the top of the right-hand column)
  • Confirmed that the image appears as a thumbnail preview

Terminal_Pre_HC.svg is not fixable in this way, and I don't understand
svg well enough to troubleshoot easily.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/9226 **State:** closed **Merged:** Yes --- A header line is missing from a few `.svg` files, denying their use (via a security error) in WordPress (if svg support is enabled). The upload is rejected even though the web browser could display the image if it were dragged into its own tab. The `.svg` images appear to have been edited at different times and with different tools. Their contents are in a different style. Two of them are beautiful and the rest do not follow suit and do not function the same. I don't know enough to make them all the same style, but changes can be made to three of them to make them work the way I was expecting (see below). ## Validation Steps Performed - Perform the change with a text editor - Open a new WordPress post page - Drag-and-drop the changed file into that WordPress edit box - (The WordPress media upload dialog appears and the file is uploaded) - Confirmed that the file does not trigger a "security error" (as seen at the top of the right-hand column) - Confirmed that the image appears as a thumbnail preview `Terminal_Pre_HC.svg` is not fixable in this way, and I don't understand svg well enough to troubleshoot easily.
claunia added the pull-request label 2026-01-31 09:22:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27487
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?