starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9253] [MERGED] Add a simple page for keybindings #27490

New Issue
Open
opened 2026-01-31 09:22:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:22:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9253
Author: @zadjii-msft
Created: 2/23/2021
Status: ✅ Merged
Merged: 2/23/2021
Merged by: @undefined

Base: main ← Head: dev/migrie/actions-list

📝 Commits (10+)

  • bc0a953 what the fuck?
  • 1985362 rename Command::Icon -> Command->IconPath, because XAML is a MADHOUSE
  • e4c4349 Update the icon
  • 9086b15 Filter commands we don't need
  • 9aaa1bf Update the BG to match the command palette
  • aeb1093 remove some unused styles; add comments
  • 9316519 that looks good to me
  • 6e354e9 yep that worked
  • 05d48ca some trivial wording nits
  • 764b07c Align the tooltip, and change the text to what @cinnamon-msft wanted

📊 Changes

13 files changed (+446 additions, -78 deletions)

View changed files

📝 src/cascadia/TerminalApp/ActionPaletteItem.cpp (+3 -3)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+14 -8)
➕ src/cascadia/TerminalSettingsEditor/Actions.cpp (+61 -0)
➕ src/cascadia/TerminalSettingsEditor/Actions.h (+49 -0)
➕ src/cascadia/TerminalSettingsEditor/Actions.idl (+23 -0)
➕ src/cascadia/TerminalSettingsEditor/Actions.xaml (+190 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+13 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.xaml (+42 -35)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+13 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+34 -28)
📝 src/cascadia/TerminalSettingsModel/Command.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsModel/Command.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/Command.idl (+1 -1)

📄 Description

This was the only thing blocking me from signing off on #9224 in 1.7.

! CHANGE WARNING !
If we bind to T.S.M.Commands in XAML, then the compiler gets very
angry at us. It generates two different versions of
GetReferenceTypeMember_Icon in XamlTypeInfo.g.cpp. Presumably
because there's an Icon on a NavViewItem and an Icon on a Command. We
don't really know why. Fortunately, the fix is "rename Command::Icon" to
"Command::IconPath". It's dumb, but it works. Thanks for the help with
that one Carlos ☺️

Unblocks #9224

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9253 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 2/23/2021 **Status:** ✅ Merged **Merged:** 2/23/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/actions-list` --- ### 📝 Commits (10+) - [`bc0a953`](https://github.com/microsoft/terminal/commit/bc0a95377a54c4b3ba0331274824dafbfde94864) what the fuck? - [`1985362`](https://github.com/microsoft/terminal/commit/1985362822f710ab6ae49b330bcb4022ea04b86e) rename Command::Icon -> Command->IconPath, because XAML is a MADHOUSE - [`e4c4349`](https://github.com/microsoft/terminal/commit/e4c434976530a3e2d3045d290d057b269e5db250) Update the icon - [`9086b15`](https://github.com/microsoft/terminal/commit/9086b1528250db502614aac5ea1445a02d11e72d) Filter commands we don't need - [`9aaa1bf`](https://github.com/microsoft/terminal/commit/9aaa1bfc079cf12b8365c06df564f058505b98f4) Update the BG to match the command palette - [`aeb1093`](https://github.com/microsoft/terminal/commit/aeb1093b5fcdd241b97f133177232c35f88cb24e) remove some unused styles; add comments - [`9316519`](https://github.com/microsoft/terminal/commit/93165193876b4a545b2b68e3f77cbf361c9d2ac5) that looks good to me - [`6e354e9`](https://github.com/microsoft/terminal/commit/6e354e97a0d4c013110156cf39d8c4840e0744a0) yep that worked - [`05d48ca`](https://github.com/microsoft/terminal/commit/05d48ca3e4a4bb19871a40549bd0859af4ab8542) some trivial wording nits - [`764b07c`](https://github.com/microsoft/terminal/commit/764b07c89ff56a350f971a4445022daab7fe907c) Align the tooltip, and change the text to what @cinnamon-msft wanted ### 📊 Changes **13 files changed** (+446 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/ActionPaletteItem.cpp` (+3 -3) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+14 -8) ➕ `src/cascadia/TerminalSettingsEditor/Actions.cpp` (+61 -0) ➕ `src/cascadia/TerminalSettingsEditor/Actions.h` (+49 -0) ➕ `src/cascadia/TerminalSettingsEditor/Actions.idl` (+23 -0) ➕ `src/cascadia/TerminalSettingsEditor/Actions.xaml` (+190 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+13 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.xaml` (+42 -35) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+13 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+34 -28) 📝 `src/cascadia/TerminalSettingsModel/Command.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/Command.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/Command.idl` (+1 -1) </details> ### 📄 Description This was the only thing blocking me from signing off on #9224 in 1.7. ! CHANGE WARNING ! If we bind to `T.S.M.Command`s in XAML, then the compiler gets _very angry_ at us. It generates two different versions of `GetReferenceTypeMember_Icon` in `XamlTypeInfo.g.cpp`. Presumably because there's an Icon on a NavViewItem and an Icon on a Command. We don't really know why. Fortunately, the fix is "rename Command::Icon" to "Command::IconPath". It's dumb, but it works. Thanks for the help with that one Carlos ☺️ Unblocks #9224 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27490
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?