starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9249] [MERGED] PICK: Work around an optimizer issue with SetPixelShaderPath #27494

New Issue
Open
opened 2026-01-31 09:22:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:22:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9249
Author: @DHowett
Created: 2/22/2021
Status: ✅ Merged
Merged: 2/22/2021
Merged by: @DHowett

Base: main ← Head: dev/duhowett/17opt

📝 Commits (1)

  • 7bcdb67 Work around a (likely) optimizer issue with SetPixelShaderPath (#9092)

📊 Changes

2 files changed (+74 additions, -53 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+72 -52)
📝 src/cascadia/TerminalControl/TermControl.h (+2 -1)

📄 Description

It appears as though the optimizer is generating a sequence of
instructions on x64 that results in a nonsense std::wstring_view being
passed to SetPixelShaderPath when it's converted from a winrt::hstring.

Initially, I suspected that the issue was in us caching _settings
before we broke off the coroutine to update settings on the UI thread. I
implemented a quick fix for this (applying values off the new settings
object while also storing it in the control instance), but it didn't
actually lead anywhere. I do think it's the right thing to do for code
health's sake. Pankaj already changed how this works in 1.7: we no
longer (ever) re-seat the _settings reference... we only ever change
its parentage. Whether this is right or wrong is not for this paragraph
to discuss.

Eventually, I started looking more closely at the time travel traces. It
seriously looks like the wstring_view is generated wrong to begin with.
The debugger points directly at return { L"", 0 }; (which is correct),
but the values we get immediately on the other side of the call are
something like { 0x7FFFFFFF, 0 } or { 0x0, 0x48454C4C }.

I moved just the call to SetPixelShaderPath into a separate function.
The bug miraculously disappeared when I marked it noinline. It
reappeared when the function was fully inlined.

To avoid any future issues, I moved the whole UI thread body of
UpdateSettings out into its own function, to be called only while on the
UI thread. This fixes the bug.

Closes #8723.
Closes #9064.

I found a repro (update the settings file every 0.5 seconds and resize
the terminal wildly while it's doing so) that would trigger the bug
within ~10 seconds. It stopped doing so.

(cherry picked from commit 91b867102c)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9249 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 2/22/2021 **Status:** ✅ Merged **Merged:** 2/22/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/17opt` --- ### 📝 Commits (1) - [`7bcdb67`](https://github.com/microsoft/terminal/commit/7bcdb67065a53475488ce7097968fa68b854ce2c) Work around a (likely) optimizer issue with SetPixelShaderPath (#9092) ### 📊 Changes **2 files changed** (+74 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+72 -52) 📝 `src/cascadia/TerminalControl/TermControl.h` (+2 -1) </details> ### 📄 Description It appears as though the optimizer is generating a sequence of instructions on x64 that results in a nonsense std::wstring_view being passed to SetPixelShaderPath when it's converted from a winrt::hstring. Initially, I suspected that the issue was in us caching `_settings` before we broke off the coroutine to update settings on the UI thread. I implemented a quick fix for this (applying values off the new settings object while also storing it in the control instance), but it didn't actually lead anywhere. I do think it's the right thing to do for code health's sake. Pankaj already changed how this works in 1.7: we no longer (ever) re-seat the `_settings` reference... we only ever change its parentage. Whether this is right or wrong is not for this paragraph to discuss. Eventually, I started looking more closely at the time travel traces. It seriously looks like the wstring_view is generated wrong to begin with. The debugger points directly at `return { L"", 0 };` (which is correct), but the values we get immediately on the other side of the call are something like `{ 0x7FFFFFFF, 0 }` or `{ 0x0, 0x48454C4C }`. I moved _just_ the call to SetPixelShaderPath into a separate function. The bug miraculously disappeared when I marked it **noinline**. It reappeared when the function was fully inlined. To avoid any future issues, I moved the whole UI thread body of UpdateSettings out into its own function, to be called only while on the UI thread. This fixes the bug. Closes #8723. Closes #9064. I found a repro (update the settings file every 0.5 seconds and resize the terminal wildly while it's doing so) that would trigger the bug within ~10 seconds. It stopped doing so. (cherry picked from commit 91b867102c0fb9522a4fa3100f207cfa72aac3cc) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27494
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?