[PR #9271] [MERGED] Add help text to 'more options' in command palette #27501

Open
opened 2026-01-31 09:22:19 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9271
Author: @carlos-zamora
Created: 2/24/2021
Status: Merged
Merged: 2/24/2021
Merged by: @DHowett

Base: mainHead: dev/cazamor/a11y/main-cmd-plt-more-options


📝 Commits (1)

  • 7381e68 Add help text to 'more options' in command palette

📊 Changes

9 files changed (+78 additions, -98 deletions)

View changed files

📝 src/cascadia/TerminalApp/CommandPalette.xaml (+68 -5)
src/cascadia/TerminalApp/HasNestedCommandsVisibilityConverter.cpp (+0 -39)
src/cascadia/TerminalApp/HasNestedCommandsVisibilityConverter.h (+0 -27)
src/cascadia/TerminalApp/HasNestedCommandsVisibilityConverter.idl (+0 -19)
📝 src/cascadia/TerminalApp/PaletteItemTemplateSelector.cpp (+7 -0)
📝 src/cascadia/TerminalApp/PaletteItemTemplateSelector.h (+1 -0)
📝 src/cascadia/TerminalApp/PaletteItemTemplateSelector.idl (+1 -0)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+1 -1)
📝 src/cascadia/TerminalApp/TerminalAppLib.vcxproj (+0 -7)

📄 Description

Similar to #9262. This creates another data template specifically for
command palette items that open up more options. We leverage the
localization key from #9262 to apply help text to this template
automatically.

Using the data template approach, we now have no need for the
HasNestedComandsVisibilityConverter, so that set of files is now
deleted. The logic to detect nested commands was moved to the template
selector.

PR Checklist

Validation Steps Performed

Tested using NVDA.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9271 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 2/24/2021 **Status:** ✅ Merged **Merged:** 2/24/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/cazamor/a11y/main-cmd-plt-more-options` --- ### 📝 Commits (1) - [`7381e68`](https://github.com/microsoft/terminal/commit/7381e685697d728ba5ff7f01432b8d8c10eacf78) Add help text to 'more options' in command palette ### 📊 Changes **9 files changed** (+78 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CommandPalette.xaml` (+68 -5) ➖ `src/cascadia/TerminalApp/HasNestedCommandsVisibilityConverter.cpp` (+0 -39) ➖ `src/cascadia/TerminalApp/HasNestedCommandsVisibilityConverter.h` (+0 -27) ➖ `src/cascadia/TerminalApp/HasNestedCommandsVisibilityConverter.idl` (+0 -19) 📝 `src/cascadia/TerminalApp/PaletteItemTemplateSelector.cpp` (+7 -0) 📝 `src/cascadia/TerminalApp/PaletteItemTemplateSelector.h` (+1 -0) 📝 `src/cascadia/TerminalApp/PaletteItemTemplateSelector.idl` (+1 -0) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalAppLib.vcxproj` (+0 -7) </details> ### 📄 Description Similar to #9262. This creates another data template specifically for command palette items that open up more options. We leverage the localization key from #9262 to apply help text to this template automatically. Using the data template approach, we now have no need for the `HasNestedComandsVisibilityConverter`, so that set of files is now deleted. The logic to detect nested commands was moved to the template selector. ## PR Checklist * [ ] Addresses #7908 better ## Validation Steps Performed Tested using NVDA. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:19 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27501