[PR #9270] [MERGED] Add a setting to flash the pane when BEL is emitted #27502

Open
opened 2026-01-31 09:22:19 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9270
Author: @PankajBhojwani
Created: 2/24/2021
Status: ✅ Merged
Merged: 5/24/2021
Merged by: @undefined

Base: main ← Head: dev/pabhoj/bell_flash


📝 Commits (10+)

📊 Changes

21 files changed (+305 additions, -22 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+5 -3)
📝 src/cascadia/TerminalApp/Pane.cpp (+7 -2)
📝 src/cascadia/TerminalControl/TermControl.cpp (+43 -1)
📝 src/cascadia/TerminalControl/TermControl.h (+7 -0)
📝 src/cascadia/TerminalControl/TermControl.idl (+2 -0)
📝 src/cascadia/TerminalControl/TermControl.xaml (+3 -0)
📝 src/cascadia/TerminalControl/TerminalControlLib.vcxproj (+7 -0)
➕ src/cascadia/TerminalControl/XamlLights.cpp (+107 -0)
➕ src/cascadia/TerminalControl/XamlLights.h (+49 -0)
➕ src/cascadia/TerminalControl/XamlLights.idl (+13 -0)
📝 src/cascadia/TerminalSettingsEditor/Profiles.cpp (+27 -2)
📝 src/cascadia/TerminalSettingsEditor/Profiles.h (+6 -1)
📝 src/cascadia/TerminalSettingsEditor/Profiles.idl (+5 -3)
📝 src/cascadia/TerminalSettingsEditor/Profiles.xaml (+8 -3)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+7 -0)
📝 src/cascadia/TerminalSettingsModel/EnumMappings.cpp (+0 -1)
📝 src/cascadia/TerminalSettingsModel/EnumMappings.h (+0 -1)
📝 src/cascadia/TerminalSettingsModel/EnumMappings.idl (+0 -1)
📝 src/cascadia/TerminalSettingsModel/JsonUtils.h (+2 -1)
📝 src/cascadia/TerminalSettingsModel/Profile.idl (+3 -1)

...and 1 more files

📄 Description

Summary of the Pull Request

Adds a new bellStyle called window. When window is set and a BEL is emitted, we flash the pane that emitted it.

Additionally, changes bellStyle in the SUI to a list of checkboxes instead of radio buttons, to match bellStyle being a flag-enum. Deprecates 'BellStyle::Visual' in the schema, but still allows it to be set in the json (it maps to Window | Taskbar)

References

#6700

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

GIF in Teams


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9270 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 2/24/2021 **Status:** ✅ Merged **Merged:** 5/24/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/bell_flash` --- ### 📝 Commits (10+) - [`370e0c0`](https://github.com/microsoft/terminal/commit/370e0c0d4415122ccd5c505860e45654af885e27) initial - [`3d7c9db`](https://github.com/microsoft/terminal/commit/3d7c9dbb65e1ff7d169087e9dee777ce3dcd6beb) optional timer - [`54a683d`](https://github.com/microsoft/terminal/commit/54a683dd86555b04b3385681bed4e122473cedbd) add setting - [`b4ae30c`](https://github.com/microsoft/terminal/commit/b4ae30c5bc65fe9f77bc8b8ac7abb94d410537e1) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/bell_flash - [`d59a432`](https://github.com/microsoft/terminal/commit/d59a4324a98eca7160cdc7017636c170b33574c4) change timer - [`c1172cd`](https://github.com/microsoft/terminal/commit/c1172cd782ffb687e949ad125238791c0bf40d97) format - [`e0c9f89`](https://github.com/microsoft/terminal/commit/e0c9f899eac2f046f6dff9cf1fea7b3732877a7e) stash, lock - [`e89f273`](https://github.com/microsoft/terminal/commit/e89f273e6c8ee5e8ec24c3a920023597cfabedfc) weak this - [`f93c9e8`](https://github.com/microsoft/terminal/commit/f93c9e873fc884057b8448c6c100885867149168) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/bell_flash - [`4c125c3`](https://github.com/microsoft/terminal/commit/4c125c32477c5aeafc4e7cc7b9cdec481583c5c8) resw, schema ### 📊 Changes **21 files changed** (+305 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+5 -3) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+7 -2) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+43 -1) 📝 `src/cascadia/TerminalControl/TermControl.h` (+7 -0) 📝 `src/cascadia/TerminalControl/TermControl.idl` (+2 -0) 📝 `src/cascadia/TerminalControl/TermControl.xaml` (+3 -0) 📝 `src/cascadia/TerminalControl/TerminalControlLib.vcxproj` (+7 -0) ➕ `src/cascadia/TerminalControl/XamlLights.cpp` (+107 -0) ➕ `src/cascadia/TerminalControl/XamlLights.h` (+49 -0) ➕ `src/cascadia/TerminalControl/XamlLights.idl` (+13 -0) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+27 -2) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.h` (+6 -1) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.idl` (+5 -3) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.xaml` (+8 -3) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+7 -0) 📝 `src/cascadia/TerminalSettingsModel/EnumMappings.cpp` (+0 -1) 📝 `src/cascadia/TerminalSettingsModel/EnumMappings.h` (+0 -1) 📝 `src/cascadia/TerminalSettingsModel/EnumMappings.idl` (+0 -1) 📝 `src/cascadia/TerminalSettingsModel/JsonUtils.h` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/Profile.idl` (+3 -1) _...and 1 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds a new bellStyle called `window`. When `window` is set and a BEL is emitted, we flash the pane that emitted it. Additionally, changes bellStyle in the SUI to a list of checkboxes instead of radio buttons, to match bellStyle being a flag-enum. Deprecates 'BellStyle::Visual' in the schema, but still allows it to be set in the json (it maps to `Window | Taskbar`) <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #6700 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed GIF in Teams --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:19 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27502