[PR #9318] [MERGED] Move TerminalSettings from TermApp to TerminalSettingsModel #27531

Open
opened 2026-01-31 09:22:32 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9318
Author: @carlos-zamora
Created: 3/1/2021
Status: Merged
Merged: 3/15/2021
Merged by: @undefined

Base: mainHead: dev/cazamor/sui/move-term-sets


📝 Commits (9)

  • cae4ec7 Move TerminalSettings from TermApp to TSM
  • 1e968fd polish PR for review
  • 187a510 Merge branch 'main' into dev/cazamor/sui/move-term-sets
  • fc26768 fix tests (verified)
  • e2fb1e7 Merge branch 'main' into dev/cazamor/sui/move-term-sets
  • 0eaf930 add comment for BuildSettings
  • 3de9894 address Dustin's PR comments
  • 1321d76 a bit more polish
  • f3ac13a Merge branch 'main' into dev/cazamor/sui/move-term-sets

📊 Changes

19 files changed (+779 additions, -689 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/SettingsModel.LocalTests.vcxproj (+1 -0)
src/cascadia/LocalTests_SettingsModel/TerminalSettingsTests.cpp (+543 -0)
📝 src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp (+0 -491)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+3 -4)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+1 -1)
📝 src/cascadia/TerminalApp/Pane.cpp (+1 -4)
📝 src/cascadia/TerminalApp/Pane.h (+1 -1)
📝 src/cascadia/TerminalApp/TerminalAppLib.vcxproj (+0 -7)
📝 src/cascadia/TerminalApp/TerminalAppLib.vcxproj.filters (+1 -10)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+13 -11)
📝 src/cascadia/TerminalApp/TerminalPage.h (+3 -4)
src/cascadia/TerminalApp/TerminalSettings.h (+0 -132)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+1 -1)
📝 src/cascadia/TerminalApp/TerminalTab.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/IInheritable.h (+5 -5)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj (+7 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+52 -16)
src/cascadia/TerminalSettingsModel/TerminalSettings.h (+136 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.idl (+10 -1)

📄 Description

This accomplishes the first step towards embedding a preview on the Profiles/ColorSchemes page, by moving the TerminalSettings object over to the Terminal Settings Model project. We'll leverage this in a later PR to construct an embedded terminal in the settings UI.

TerminalSettings had to see a few more functions exposed in the IDL
(including some inheritance stuff).

Refresh the JSON to make TerminalSettings do it's thing across all the
open terminals.

References #9122 - Terminal Preview
References #6800 - SUI Epic


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9318 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 3/1/2021 **Status:** ✅ Merged **Merged:** 3/15/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/sui/move-term-sets` --- ### 📝 Commits (9) - [`cae4ec7`](https://github.com/microsoft/terminal/commit/cae4ec72284efe94d037336c5864cc5e2b6a595e) Move TerminalSettings from TermApp to TSM - [`1e968fd`](https://github.com/microsoft/terminal/commit/1e968fdbc6a068331ad71a9bc26bc01956cf1616) polish PR for review - [`187a510`](https://github.com/microsoft/terminal/commit/187a5101b5face6d15d471bb799c0b195fdaf779) Merge branch 'main' into dev/cazamor/sui/move-term-sets - [`fc26768`](https://github.com/microsoft/terminal/commit/fc26768bcd2f926f6d8a7c832de225236bdac40c) fix tests (verified) - [`e2fb1e7`](https://github.com/microsoft/terminal/commit/e2fb1e70bdae94a42040219ac2c691bb0fc51aa5) Merge branch 'main' into dev/cazamor/sui/move-term-sets - [`0eaf930`](https://github.com/microsoft/terminal/commit/0eaf930221a1135ae123b226c63998c9096fe116) add comment for BuildSettings - [`3de9894`](https://github.com/microsoft/terminal/commit/3de9894b8421a7ce1a578419e39a5edf9da85e5b) address Dustin's PR comments - [`1321d76`](https://github.com/microsoft/terminal/commit/1321d76827ae8451785c1ce9a7224299bda693c7) a bit more polish - [`f3ac13a`](https://github.com/microsoft/terminal/commit/f3ac13af504fe9ad91448356c6473237849f34f5) Merge branch 'main' into dev/cazamor/sui/move-term-sets ### 📊 Changes **19 files changed** (+779 additions, -689 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/SettingsModel.LocalTests.vcxproj` (+1 -0) ➕ `src/cascadia/LocalTests_SettingsModel/TerminalSettingsTests.cpp` (+543 -0) 📝 `src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp` (+0 -491) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+3 -4) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+1 -4) 📝 `src/cascadia/TerminalApp/Pane.h` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalAppLib.vcxproj` (+0 -7) 📝 `src/cascadia/TerminalApp/TerminalAppLib.vcxproj.filters` (+1 -10) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+13 -11) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+3 -4) ➖ `src/cascadia/TerminalApp/TerminalSettings.h` (+0 -132) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/IInheritable.h` (+5 -5) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj` (+7 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+52 -16) ➕ `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+136 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.idl` (+10 -1) </details> ### 📄 Description This accomplishes the first step towards embedding a preview on the Profiles/ColorSchemes page, by moving the `TerminalSettings` object over to the Terminal Settings Model project. We'll leverage this in a later PR to construct an embedded terminal in the settings UI. `TerminalSettings` had to see a few more functions exposed in the IDL (including some inheritance stuff). Refresh the JSON to make TerminalSettings do it's thing across all the open terminals. References #9122 - Terminal Preview References #6800 - SUI Epic --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:32 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27531