starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9358] Show the context menu verb only when shift key is down #27546

New Issue
Open
opened 2026-01-31 09:22:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:22:36 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/9358

State: closed
Merged: No

Summary of the Pull Request

  • Show the context menu verb only when shift key is down. Not configurable right now. Add a config in the future, maybe?
  • Change the verb name a bit to keep it consistent with the existing "Open PowerShell window here". Anyway this should be overridden by #6112 at some point.

References

Related: #8105

PR Checklist

  • Closes If command description error (#6113)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/ passed (Invoke-OpenConsoleTests Total=329, Passed=329)
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Haven't found a proper way to test ShellExtension so I went creative: (much appreciated if anybody can point me to the proper way to test this :p)

  • Installed Windows Terminal (stable) from Microsoft Store
  • Built x64 Release WindowsTerminalShellExt.dll
  • Copied built WindowsTerminalShellExt.dll under C:\Program Files\WindowsApps\
  • (Optional) Copied WindowsTerminal.exe under C:\Program Files\WindowsApps\ for verb icon
  • Under HKCR\PackagedCom\Package\Microsoft.WindowsTerminal_1.6.10571.0_x64__8wekyb3d8bbwe\Class\{9F156763-7844-4DC4-B2B1-901F640F5155}\, changed DllPath to ..\WindowsTerminalShellExt.dll
  • Manually verified the change in explorer -- works as expected.

In a folder, shift up;
1 in dir shift up

In a folder, shift down:
2 in dir shift down

On a folder, shift up:
3 on dir shift up

On a folder, shift down:
4 on dir shift down

**Original Pull Request:** https://github.com/microsoft/terminal/pull/9358 **State:** closed **Merged:** No --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request - Show the context menu verb only when shift key is down. Not configurable right now. Add a config in the future, maybe? - Change the verb name a bit to keep it consistent with the existing "Open PowerShell window here". Anyway this should be overridden by #6112 at some point. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References Related: #8105 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #6113 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests ~~added/~~ passed (`Invoke-OpenConsoleTests` Total=329, Passed=329) * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Haven't found a proper way to test ShellExtension so I went creative: (much appreciated if anybody can point me to the proper way to test this :p) - Installed Windows Terminal (stable) from Microsoft Store - Built x64 Release WindowsTerminalShellExt.dll - Copied built WindowsTerminalShellExt.dll under `C:\Program Files\WindowsApps\` - (Optional) Copied WindowsTerminal.exe under `C:\Program Files\WindowsApps\` for verb icon - Under `HKCR\PackagedCom\Package\Microsoft.WindowsTerminal_1.6.10571.0_x64__8wekyb3d8bbwe\Class\{9F156763-7844-4DC4-B2B1-901F640F5155}\`, changed `DllPath` to `..\WindowsTerminalShellExt.dll` - Manually verified the change in explorer -- works as expected. In a folder, shift up; <img width="182" alt="1 in dir shift up" src="https://user-images.githubusercontent.com/10822203/109811516-cbad7c80-7bdf-11eb-8143-190414a7ff00.png"> In a folder, shift down: <img width="212" alt="2 in dir shift down" src="https://user-images.githubusercontent.com/10822203/109811528-d1a35d80-7bdf-11eb-956a-18615570ef49.png"> On a folder, shift up: <img width="224" alt="3 on dir shift up" src="https://user-images.githubusercontent.com/10822203/109811563-dcf68900-7bdf-11eb-894c-c43b2a53c967.png"> On a folder, shift down: <img width="244" alt="4 on dir shift down" src="https://user-images.githubusercontent.com/10822203/109811592-e4b62d80-7bdf-11eb-8aed-06d1bf073038.png">
claunia added the pull-request label 2026-01-31 09:22:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27546
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?