[PR #9352] Create a new page for "Add new profile" in the SUI #27547

Open
opened 2026-01-31 09:22:37 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/9352

State: closed
Merged: Yes


  • Whenever we add a new profile setting from now on we have to update
    Profile::CopySettings and CascadiaSettings::DuplicateProfile 👎

Notes from bug bash (checked bugs have been resolved):

  • The duplicate list can be very long if you have profiles
  • DH: "Create new" seems too vague. "New empty profile" or something
    seems a little clearer to me.
  • There is no deduplication counter for name
  • Crash when your settings file is corrupt and we had to fall back
    to the defaults and you duplicate a profile
  • Crash due to `closeTabsAfter` doesn't resize the tabs until you mouseover them (#10003)

PR Checklist

**Original Pull Request:** https://github.com/microsoft/terminal/pull/9352 **State:** closed **Merged:** Yes --- - Whenever we add a new profile setting from now on we have to update `Profile::CopySettings` _and_ `CascadiaSettings::DuplicateProfile` 👎 Notes from bug bash (checked bugs have been resolved): - [ ] The duplicate list can be very long if you have profiles - [x] DH: "Create new" seems too vague. "New empty profile" or something seems a little clearer to me. - [x] There is no deduplication counter for name - [x] Crash when your settings file is corrupt and we had to fall back to the defaults and you duplicate a profile - [x] Crash due to #10003 ## PR Checklist * [x] Closes #9121
claunia added the pull-request label 2026-01-31 09:22:37 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27547