starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9384] [CLOSED] Fix selection logic with shift on multi-click and in mouse mode #27550

New Issue
Open
opened 2026-01-31 09:22:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:22:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9384
Author: @Don-Vito
Created: 3/5/2021
Status: ❌ Closed

Base: main ← Head: 9382-no-extend-sel-doubleclick

📝 Commits (2)

  • 7cca19d Fix selection not to extend on multi-click
  • 1aa147f Introduce selection reset on anchor / same position click

📊 Changes

2 files changed (+46 additions, -21 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+45 -21)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)

📄 Description

PR Checklist

Detailed Description of the Pull Request / Additional comments

Currently, if selection is active, all clicks with shift pressed extend it,
i.e., shift+click, shift+double-click, shift+triple-click extend the selection
from anchor start to the current position.

While we can argue the correctness of this UX in general
(hint the terminals I checked usually do something else),
it is fully broken by #8611, that introduced cell selection on shift+click.
Currently, upon shift+double-click:

  • the first click sets the selection
  • the second click simply extends it
    So instead of the word we get only partial selection.

To address this I suggest to change the selection logic to:
extend only on a single-click.
I.e., shift+double-click will select a word rather than
extending an existing selection.

This is how it works in ConEmu.
However MinTTY have even smarter solution
where shift+double-click adds a word to existing selection.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9384 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 3/5/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `9382-no-extend-sel-doubleclick` --- ### 📝 Commits (2) - [`7cca19d`](https://github.com/microsoft/terminal/commit/7cca19d13f77187bce836b510376b52f6ceb19eb) Fix selection not to extend on multi-click - [`1aa147f`](https://github.com/microsoft/terminal/commit/1aa147f181f2c3b20749bbbbe3e6f9edb3925d31) Introduce selection reset on anchor / same position click ### 📊 Changes **2 files changed** (+46 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+45 -21) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) </details> ### 📄 Description ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/issues/9382 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments Currently, if selection is active, all clicks with `shift` pressed extend it, i.e., `shift+click`, `shift+double-click`, `shift+triple-click` extend the selection from anchor start to the current position. While we can argue the correctness of this UX in general (hint the terminals I checked usually do something else), it is fully broken by #8611, that introduced cell selection on `shift+click`. Currently, upon `shift+double-click`: * the first click sets the selection * the second click simply extends it So instead of the word we get only partial selection. To address this I suggest to change the selection logic to: extend only on a `single-click`. I.e., `shift+double-click` will select a word rather than extending an existing selection. This is how it works in ConEmu. However MinTTY have even smarter solution where `shift+double-click` adds a word to existing selection. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27550
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?