[PR #9376] [MERGED] Replace some of our macros to reduce confusion, increase success #27554

Open
opened 2026-01-31 09:22:39 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9376
Author: @zadjii-msft
Created: 3/4/2021
Status: Merged
Merged: 3/4/2021
Merged by: @DHowett

Base: mainHead: dev/migrie/b/SETTING


📝 Commits (6)

  • d9dc68b s/GETSET_SETTING/SETTING/g ; s/GETSET_NULLABLE_SETTING/NULLABLE_SETTING/g
  • 3f283d2 s/NULLABLE_SETTING/INHERITABLE_NULLABLE_SETTING/g
  • 36bc016 s/ SETTING/ INHERITABLE_SETTING/g
  • 6c12d04 s/OBSERVABLE_GETSET_PROPERTY/WINRT_OBSERVABLE_PROPERTY/g
  • ceeb811 s/GETSET_PROPERTY/WINRT_PROPERTY/g
  • 43ad433 Merge remote-tracking branch 'origin/main' into dev/migrie/b/SETTING

📊 Changes

34 files changed (+247 additions, -247 deletions)

View changed files

📝 src/cascadia/Remoting/FindTargetWindowArgs.h (+2 -2)
📝 src/cascadia/Remoting/ProposeCommandlineResult.h (+2 -2)
📝 src/cascadia/Remoting/WindowActivatedArgs.h (+4 -4)
📝 src/cascadia/ShellExtension/PlaceholderType.h (+1 -1)
📝 src/cascadia/TerminalApp/ActionPaletteItem.h (+1 -1)
📝 src/cascadia/TerminalApp/CommandLinePaletteItem.h (+1 -1)
📝 src/cascadia/TerminalApp/CommandPalette.h (+6 -6)
📝 src/cascadia/TerminalApp/FilteredCommand.h (+4 -4)
📝 src/cascadia/TerminalApp/HighlightedText.h (+3 -3)
📝 src/cascadia/TerminalApp/PaletteItem.h (+3 -3)
📝 src/cascadia/TerminalApp/PaletteItemTemplateSelector.h (+3 -3)
📝 src/cascadia/TerminalApp/TabBase.h (+7 -7)
📝 src/cascadia/TerminalApp/TabHeaderControl.h (+3 -3)
📝 src/cascadia/TerminalApp/TabPaletteItem.h (+1 -1)
📝 src/cascadia/TerminalApp/TerminalSettings.h (+44 -44)
📝 src/cascadia/TerminalApp/TerminalTabStatus.h (+6 -6)
📝 src/cascadia/TerminalControl/TSFInputControl.h (+4 -4)
📝 src/cascadia/TerminalSettingsEditor/Actions.h (+2 -2)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.h (+15 -15)
📝 src/cascadia/TerminalSettingsEditor/EnumEntry.h (+2 -2)

...and 14 more files

📄 Description

As mentioned in https://github.com/microsoft/terminal/issues/9354#issuecomment-790034728

GETSET_SETTING is too visually similar to GETSET_PROPERTY, but with a VERY different meaning. I think that merely changing the name of the macro would make it harder for us to make this mistake again.

  • will inevitably conflict with #9371
  • scratches an itch
  • I work here

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9376 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/4/2021 **Status:** ✅ Merged **Merged:** 3/4/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/migrie/b/SETTING` --- ### 📝 Commits (6) - [`d9dc68b`](https://github.com/microsoft/terminal/commit/d9dc68b2b9ea1b607ac05e0fa2adae475a0f29a8) s/GETSET_SETTING/SETTING/g ; s/GETSET_NULLABLE_SETTING/NULLABLE_SETTING/g - [`3f283d2`](https://github.com/microsoft/terminal/commit/3f283d28c5a24cd7137ddf9a7986afca7aaef059) s/NULLABLE_SETTING/INHERITABLE_NULLABLE_SETTING/g - [`36bc016`](https://github.com/microsoft/terminal/commit/36bc016740c2722ce4fc213c501b81ff3f140aec) s/ SETTING/ INHERITABLE_SETTING/g - [`6c12d04`](https://github.com/microsoft/terminal/commit/6c12d045c932ac9d55e94e0b05b811a3c76c13ae) s/OBSERVABLE_GETSET_PROPERTY/WINRT_OBSERVABLE_PROPERTY/g - [`ceeb811`](https://github.com/microsoft/terminal/commit/ceeb8111dc62e58e05a159569ac693da9317b6e3) s/GETSET_PROPERTY/WINRT_PROPERTY/g - [`43ad433`](https://github.com/microsoft/terminal/commit/43ad43385c3d904877a0edf6bb929ab592d49504) Merge remote-tracking branch 'origin/main' into dev/migrie/b/SETTING ### 📊 Changes **34 files changed** (+247 additions, -247 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/Remoting/FindTargetWindowArgs.h` (+2 -2) 📝 `src/cascadia/Remoting/ProposeCommandlineResult.h` (+2 -2) 📝 `src/cascadia/Remoting/WindowActivatedArgs.h` (+4 -4) 📝 `src/cascadia/ShellExtension/PlaceholderType.h` (+1 -1) 📝 `src/cascadia/TerminalApp/ActionPaletteItem.h` (+1 -1) 📝 `src/cascadia/TerminalApp/CommandLinePaletteItem.h` (+1 -1) 📝 `src/cascadia/TerminalApp/CommandPalette.h` (+6 -6) 📝 `src/cascadia/TerminalApp/FilteredCommand.h` (+4 -4) 📝 `src/cascadia/TerminalApp/HighlightedText.h` (+3 -3) 📝 `src/cascadia/TerminalApp/PaletteItem.h` (+3 -3) 📝 `src/cascadia/TerminalApp/PaletteItemTemplateSelector.h` (+3 -3) 📝 `src/cascadia/TerminalApp/TabBase.h` (+7 -7) 📝 `src/cascadia/TerminalApp/TabHeaderControl.h` (+3 -3) 📝 `src/cascadia/TerminalApp/TabPaletteItem.h` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalSettings.h` (+44 -44) 📝 `src/cascadia/TerminalApp/TerminalTabStatus.h` (+6 -6) 📝 `src/cascadia/TerminalControl/TSFInputControl.h` (+4 -4) 📝 `src/cascadia/TerminalSettingsEditor/Actions.h` (+2 -2) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.h` (+15 -15) 📝 `src/cascadia/TerminalSettingsEditor/EnumEntry.h` (+2 -2) _...and 14 more files_ </details> ### 📄 Description As mentioned in https://github.com/microsoft/terminal/issues/9354#issuecomment-790034728 `GETSET_SETTING` is too visually similar to `GETSET_PROPERTY`, but with a _VERY_ different meaning. I think that merely changing the name of the macro would make it harder for us to make this mistake again. * [x] will inevitably conflict with #9371 * [x] scratches an itch * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:39 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27554