[PR #9428] [MERGED] [Spec] Settings Model - Actions #27571

Open
opened 2026-01-31 09:22:46 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9428
Author: @carlos-zamora
Created: 3/9/2021
Status: Merged
Merged: 5/5/2021
Merged by: @undefined

Base: mainHead: dev/cazamor/spec/tsm-actions


📝 Commits (9)

📊 Changes

2 files changed (+345 additions, -0 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+1 -0)
doc/specs/#885 - Terminal Settings Model/Actions Addendum.md (+344 -0)

📄 Description

This spec covers the settings model work required to create the Actions page in the settings UI (designed in #9427).

Overall, the idea is to promote Command to include the actual KeyChord, then introduce an ActionMap that handles all of the responsibilities of KeyMapping and more (as well as general action management).

Markdown view


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9428 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 3/9/2021 **Status:** ✅ Merged **Merged:** 5/5/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/spec/tsm-actions` --- ### 📝 Commits (9) - [`3905c49`](https://github.com/microsoft/terminal/commit/3905c49ca764cebced478ef310aed9f78aa842f2) [Spec] Settings Model - Actions - [`40f817b`](https://github.com/microsoft/terminal/commit/40f817b38f22c92a6971993df741407ae27ff96d) maybe this'll fix the references? - [`f1efe1a`](https://github.com/microsoft/terminal/commit/f1efe1ae418cc7b66d2002836d7e366ea2281e63) apply feedback from spec meeting & comments - [`75f486b`](https://github.com/microsoft/terminal/commit/75f486ba0421a66fb2e1f48787c15f4c925d29b9) spell check - [`de7cba9`](https://github.com/microsoft/terminal/commit/de7cba9805e91a70e0b364ae2a8844131f6eb7e4) Apply the lessons I've learned - [`71060b9`](https://github.com/microsoft/terminal/commit/71060b98a72ff21088f6ef0bc3af312c0a9375cb) apply PR feedback - [`71ee4ca`](https://github.com/microsoft/terminal/commit/71ee4ca8f80c3bddc7dd95434d2fcba0da6c38ee) resolve PR comments from Dustin - [`02dd1b8`](https://github.com/microsoft/terminal/commit/02dd1b8bb70c2cbb638e74fca25e345c955b51bb) consolidated actions - [`0485a87`](https://github.com/microsoft/terminal/commit/0485a8739cabdbc78fff180f8447a9a6979add48) spell fix ### 📊 Changes **2 files changed** (+345 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+1 -0) ➕ `doc/specs/#885 - Terminal Settings Model/Actions Addendum.md` (+344 -0) </details> ### 📄 Description This spec covers the settings model work required to create the Actions page in the settings UI (designed in #9427). Overall, the idea is to promote `Command` to include the actual `KeyChord`, then introduce an `ActionMap` that handles all of the responsibilities of `KeyMapping` and more (as well as general action management). [Markdown view](https://github.com/microsoft/terminal/blob/dev/cazamor/spec/tsm-actions/doc/specs/%23885%20-%20Terminal%20Settings%20Model/Actions%20Addendum.md) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:46 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27571