starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9495] [MERGED] Invalidate nested command with no valid subcommands #27601

New Issue
Open
opened 2026-01-31 09:22:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:22:56 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9495
Author: @Don-Vito
Created: 3/14/2021
Status: ✅ Merged
Merged: 3/15/2021
Merged by: @undefined

Base: main ← Head: 9448-empty-nested-command

📝 Commits (2)

  • 63c00bc Invalidate nested command with no valid subcommands
  • bfa47f9 Add UT asserting no invalid command is created

📊 Changes

7 files changed (+82 additions, -8 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/DeserializationTests.cpp (+57 -6)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+2 -1)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+4 -1)
📝 src/cascadia/TerminalApp/ShortcutActionDispatch.cpp (+5 -0)
📝 src/cascadia/TerminalSettingsModel/Command.cpp (+6 -0)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp (+7 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalWarnings.idl (+1 -0)

📄 Description

Currently, when loading command with sub-commands that fail to parse,
we result with command that:

  • Is not considered nested (has no sub-commands)
  • Has no action of its own

The commit contains a few changes:

  1. Protection in the dispatch that will prevent NPE
  2. Change in the command parsing that will no load
    a command if all its sub-commands failed to parse
  3. We will add a warning in this case (the solution is somewhat
    hacky, due to the hack that was there previously)

When such command is passed to a dispatch we crash with NPE.

Closes #9448

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9495 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 3/14/2021 **Status:** ✅ Merged **Merged:** 3/15/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `9448-empty-nested-command` --- ### 📝 Commits (2) - [`63c00bc`](https://github.com/microsoft/terminal/commit/63c00bc10832d7688d6748555f781990c26bb684) Invalidate nested command with no valid subcommands - [`bfa47f9`](https://github.com/microsoft/terminal/commit/bfa47f922b6a388405bfa039ad6ef4d1cf382e6a) Add UT asserting no invalid command is created ### 📊 Changes **7 files changed** (+82 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/DeserializationTests.cpp` (+57 -6) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+2 -1) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+4 -1) 📝 `src/cascadia/TerminalApp/ShortcutActionDispatch.cpp` (+5 -0) 📝 `src/cascadia/TerminalSettingsModel/Command.cpp` (+6 -0) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp` (+7 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalWarnings.idl` (+1 -0) </details> ### 📄 Description Currently, when loading command with sub-commands that fail to parse, we result with command that: * Is not considered nested (has no sub-commands) * Has no action of its own The commit contains a few changes: 1. Protection in the dispatch that will prevent NPE 2. Change in the command parsing that will no load a command if all its sub-commands failed to parse 3. We will add a warning in this case (the solution is somewhat hacky, due to the hack that was there previously) When such command is passed to a dispatch we crash with NPE. Closes #9448 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:22:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27601
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?