[PR #9527] [MERGED] Show a preview of the control in the SUI #27618

Open
opened 2026-01-31 09:23:05 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9527
Author: @PankajBhojwani
Created: 3/17/2021
Status: Merged
Merged: 5/17/2021
Merged by: @DHowett

Base: mainHead: dev/pabhoj/sui_control_preview


📝 Commits (10+)

📊 Changes

11 files changed (+128 additions, -10 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+5 -0)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.idl (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+4 -4)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+4 -0)
src/cascadia/TerminalSettingsEditor/PreviewConnection.cpp (+38 -0)
src/cascadia/TerminalSettingsEditor/PreviewConnection.h (+35 -0)
📝 src/cascadia/TerminalSettingsEditor/Profiles.cpp (+25 -3)
📝 src/cascadia/TerminalSettingsEditor/Profiles.h (+7 -1)
📝 src/cascadia/TerminalSettingsEditor/Profiles.idl (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Profiles.xaml (+7 -1)

📄 Description

In the 'Appearance' tab of a profile, show a preview of what the control looks like

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9527 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 3/17/2021 **Status:** ✅ Merged **Merged:** 5/17/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/pabhoj/sui_control_preview` --- ### 📝 Commits (10+) - [`655e277`](https://github.com/microsoft/terminal/commit/655e2779e7fcc0537d6e14d5f198c2d23b1b0035) initial - [`df21383`](https://github.com/microsoft/terminal/commit/df2138399617044cb0667f05f701938cc85305b2) conflict - [`8fb913b`](https://github.com/microsoft/terminal/commit/8fb913bcd7c04da70376615bba921e793cfa5ff9) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/sui_control_preview - [`4573552`](https://github.com/microsoft/terminal/commit/4573552b40a48f5b9e39a495d658825ba47b135f) nits - [`fb498a2`](https://github.com/microsoft/terminal/commit/fb498a20b8689c2c91fb70abc7205df16d1ac11e) merge main, remove input, move preview to above pivot - [`e169044`](https://github.com/microsoft/terminal/commit/e16904419d8b0e2a930165aa9dc8bb084d7763e9) preview text with color, update the control size with the window size - [`bab15fa`](https://github.com/microsoft/terminal/commit/bab15fa068643d3d7024054754c60410cdef3898) format - [`40b8dab`](https://github.com/microsoft/terminal/commit/40b8dab4ce913828fab00a00c6104205257f6e9d) reduce height, make not focusable - [`3884568`](https://github.com/microsoft/terminal/commit/38845682dca0f9e875f9199528a172d7738a33a5) conflict - [`ae344fc`](https://github.com/microsoft/terminal/commit/ae344fc62f8fe9224ea02b201cafb8da1b8ed000) no more localized text, control-style preview text ### 📊 Changes **11 files changed** (+128 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+5 -0) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+4 -4) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+4 -0) ➕ `src/cascadia/TerminalSettingsEditor/PreviewConnection.cpp` (+38 -0) ➕ `src/cascadia/TerminalSettingsEditor/PreviewConnection.h` (+35 -0) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+25 -3) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.h` (+7 -1) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.xaml` (+7 -1) </details> ### 📄 Description In the 'Appearance' tab of a profile, show a preview of what the control looks like ## PR Checklist * [x] Closes #9122 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:23:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27618