starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9605] [MERGED] WriteCharsLegacy: Add some notes in comments and rename WC_ECHO #27652

New Issue
Open
opened 2026-01-31 09:23:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:23:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9605
Author: @DHowett
Created: 3/24/2021
Status: ✅ Merged
Merged: 3/24/2021
Merged by: @DHowett

Base: main ← Head: dev/duhowett/wcl-comments

📝 Commits (3)

  • fc4f35a Add some notes to WriteCharsLegacy (comments only)
  • bc5b0ec WCL: Rename WC_ECHO to what it actually does: Printable Controls
  • 9e0672c OKAY MICHAEL

📊 Changes

8 files changed (+57 additions, -37 deletions)

View changed files

📝 src/host/CommandNumberPopup.cpp (+2 -2)
📝 src/host/_stream.cpp (+29 -9)
📝 src/host/_stream.h (+3 -3)
📝 src/host/cmdline.cpp (+12 -12)
📝 src/host/cmdline.h (+1 -1)
📝 src/host/misc.cpp (+4 -4)
📝 src/host/misc.h (+1 -1)
📝 src/host/readDataCooked.cpp (+5 -5)

📄 Description

This commit clarifies some things inside WriteCharsLegacy by adding
comments and renaming parameter and enum names. It does not change any
logic.

WC_ECHO was used extensively to mean only one thing: whether to print
a control character like \x18 (Ctrl+X) as ^X. It's been
renamed to make that abundantly clear.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9605 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 3/24/2021 **Status:** ✅ Merged **Merged:** 3/24/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/wcl-comments` --- ### 📝 Commits (3) - [`fc4f35a`](https://github.com/microsoft/terminal/commit/fc4f35a8ab8dc15ec92b417ae856075fdc8aa081) Add some notes to WriteCharsLegacy (comments only) - [`bc5b0ec`](https://github.com/microsoft/terminal/commit/bc5b0ecc98453fbdd32d7ed41b1611b09e167748) WCL: Rename WC_ECHO to what it actually does: Printable Controls - [`9e0672c`](https://github.com/microsoft/terminal/commit/9e0672c2ab31d6164c7cb645dc07c284148e41be) OKAY MICHAEL ### 📊 Changes **8 files changed** (+57 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/host/CommandNumberPopup.cpp` (+2 -2) 📝 `src/host/_stream.cpp` (+29 -9) 📝 `src/host/_stream.h` (+3 -3) 📝 `src/host/cmdline.cpp` (+12 -12) 📝 `src/host/cmdline.h` (+1 -1) 📝 `src/host/misc.cpp` (+4 -4) 📝 `src/host/misc.h` (+1 -1) 📝 `src/host/readDataCooked.cpp` (+5 -5) </details> ### 📄 Description This commit clarifies some things inside WriteCharsLegacy by adding comments and renaming parameter and enum names. It does not change any logic. `WC_ECHO` was used extensively to mean only one thing: whether to print a control character like `\x18` (<kbd>Ctrl+X</kbd>) as `^X`. It's been renamed to make that abundantly clear. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:23:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27652
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?