[PR #9653] [MERGED] Sort fonts alphabetically #27679

Open
opened 2026-01-31 09:23:26 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9653
Author: @kovdu
Created: 3/29/2021
Status: Merged
Merged: 3/29/2021
Merged by: @carlos-zamora

Base: mainHead: 9594-sort-fonts-alphabetically


📝 Commits (1)

  • 9525e0a Sort fonts alphabetically.

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Profiles.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsEditor/Profiles.h (+8 -0)

📄 Description

PR Checklist

  • Closes Can't reorder tabs when running as Administrator (#9594)
  • [x ] CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Validated this only by following the issue description and verified fonts appeared to be sorted alphabetically now.

Happy to add automated tests as well but would need some help where to add these since I'm probably overlooking where fonts are covered now.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9653 **Author:** [@kovdu](https://github.com/kovdu) **Created:** 3/29/2021 **Status:** ✅ Merged **Merged:** 3/29/2021 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `main` ← **Head:** `9594-sort-fonts-alphabetically` --- ### 📝 Commits (1) - [`9525e0a`](https://github.com/microsoft/terminal/commit/9525e0aa81a29d7049628fbfc49f01ef40c4a92c) Sort fonts alphabetically. ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.h` (+8 -0) </details> ### 📄 Description <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #9594 * [x ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Validated this only by following the issue description and verified fonts appeared to be sorted alphabetically now. Happy to add automated tests as well but would need some help where to add these since I'm probably overlooking where fonts are covered now. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:23:26 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27679