starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9677] [MERGED] Create a control unittesting project #27699

New Issue
Open
opened 2026-01-31 09:23:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:23:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9677
Author: @zadjii-msft
Created: 3/31/2021
Status: ✅ Merged
Merged: 4/5/2021
Merged by: @undefined

Base: main ← Head: dev/migrie/control-unittests

📝 Commits (3)

  • 58bf8cd Create a control unittesting project
  • ba76051 Merge remote-tracking branch 'origin/main' into dev/migrie/control-unittests
  • d57599e Remove from auditmode, to match TermiminalControl.dll

📊 Changes

12 files changed (+255 additions, -70 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+1 -0)
📝 OpenConsole.sln (+74 -67)
📝 src/cascadia/TerminalControl/dll/TerminalControl.vcxproj (+5 -1)
➕ src/cascadia/UnitTests_Control/Control.UnitTests.vcxproj (+83 -0)
➕ src/cascadia/UnitTests_Control/ControlCoreTests.cpp (+31 -0)
➕ src/cascadia/UnitTests_Control/UnitTests_Control.def (+3 -0)
➕ src/cascadia/UnitTests_Control/pch.cpp (+4 -0)
➕ src/cascadia/UnitTests_Control/pch.h (+50 -0)
📝 src/server/lib/server.vcxproj (+1 -1)
📝 tools/OpenConsole.psm1 (+1 -1)
📝 tools/runut.cmd (+1 -0)
📝 tools/tests.xml (+1 -0)

📄 Description

Does what it says on the can.

This is a follow up to #9472. Now that we have a control .lib, we can add tests for it.

Unfortunately, the TermControl itself is a horrible mess. So this new unittest lib is empty for now. I'm working on actual tests as a part of #6842, but this PR is here to keep the diffs smaller.

Also, apparently server.vcxproj had the wrong GUID in it.

  • I work here
  • Adds tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9677 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/31/2021 **Status:** ✅ Merged **Merged:** 4/5/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/control-unittests` --- ### 📝 Commits (3) - [`58bf8cd`](https://github.com/microsoft/terminal/commit/58bf8cdaff122851ffb199001365b4f74f2ac8dc) Create a control unittesting project - [`ba76051`](https://github.com/microsoft/terminal/commit/ba7605141ee4433b5330a9ebf8f431e6f3fcf426) Merge remote-tracking branch 'origin/main' into dev/migrie/control-unittests - [`d57599e`](https://github.com/microsoft/terminal/commit/d57599eeac9671fa893ad338a5237278d6e44d28) Remove from auditmode, to match TermiminalControl.dll ### 📊 Changes **12 files changed** (+255 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+1 -0) 📝 `OpenConsole.sln` (+74 -67) 📝 `src/cascadia/TerminalControl/dll/TerminalControl.vcxproj` (+5 -1) ➕ `src/cascadia/UnitTests_Control/Control.UnitTests.vcxproj` (+83 -0) ➕ `src/cascadia/UnitTests_Control/ControlCoreTests.cpp` (+31 -0) ➕ `src/cascadia/UnitTests_Control/UnitTests_Control.def` (+3 -0) ➕ `src/cascadia/UnitTests_Control/pch.cpp` (+4 -0) ➕ `src/cascadia/UnitTests_Control/pch.h` (+50 -0) 📝 `src/server/lib/server.vcxproj` (+1 -1) 📝 `tools/OpenConsole.psm1` (+1 -1) 📝 `tools/runut.cmd` (+1 -0) 📝 `tools/tests.xml` (+1 -0) </details> ### 📄 Description Does what it says on the can. This is a follow up to #9472. Now that we have a control .lib, we can add tests for it. Unfortunately, the `TermControl` itself is a horrible mess. So this new unittest lib is empty for now. I'm working on actual tests as a part of #6842, but this PR is here to keep the diffs smaller. Also, apparently `server.vcxproj` had the wrong GUID in it. * [x] I work here * [x] Adds tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:23:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27699
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?