[PR #9730] [MERGED] Manually handle Enter and Escape in the Window Renamer #27708

Open
opened 2026-01-31 09:23:43 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9730
Author: @zadjii-msft
Created: 4/6/2021
Status: Merged
Merged: 4/6/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/9720-enter-esc-renamer


📝 Commits (1)

  • 25c1c8a Manually handle Enter and Escape in the Window Renamer

📊 Changes

3 files changed (+24 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+22 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -1)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+1 -0)

📄 Description

Summary of the Pull Request

In exactly the same fashion as the tab renamer, handle Enter for committing the rename, and Escape for dismissing the rename.

References

PR Checklist

Validation Steps Performed

Played with it - this feels good.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9730 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/6/2021 **Status:** ✅ Merged **Merged:** 4/6/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/9720-enter-esc-renamer` --- ### 📝 Commits (1) - [`25c1c8a`](https://github.com/microsoft/terminal/commit/25c1c8a2b73c0e2de02cd0545a977d989f9947c0) Manually handle Enter and Escape in the Window Renamer ### 📊 Changes **3 files changed** (+24 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+22 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+1 -0) </details> ### 📄 Description ## Summary of the Pull Request In exactly the same fashion as the tab renamer, handle <kbd>Enter</kbd> for committing the rename, and <kbd>Escape</kbd> for dismissing the rename. ## References * Added in #9662 ## PR Checklist * [x] Closes #9720 * [x] I work here * [n/a] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Played with it - this feels good. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:23:43 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27708