[PR #9734] Reduce instances of font fallback dialog #27725

Open
opened 2026-01-31 09:23:50 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/9734

State: closed
Merged: Yes


Reduce instances of font fallback dialog through package font loading,
basic name trimming, and revised fallback test

  • Adjusts the font dialog to only show when we attempt last-chance
    resolution from our hardcoded list of font names with a flag instead
    of with a string comparison by name

  • Adds a resolution step to trim the font name by word from the end and
    retry to attempt to resolve a proper font that just has a weight
    suffix

  • Adds a second font collection to font loading that will attempt to
    locate all TTF files sitting next to our binary, like in our package

  • Wrote my font preference in the JSON as Cascadia Code Heavy and
    watched it quietly resolve to just Cascadia Code without the dialog.

  • Put a font that isn't registered with the system into the layout
    directory for the package, set it as my desired font in Terminal, and
    watched it load just fine.

  • Try a font name with different casing and see if dialog doesn't
    pop anymore

  • Try a font with different (localized) names like MS ゴシック and
    see if dialog doesn't pop anymore

  • Check Win7 with WPF target

Closes #9375

**Original Pull Request:** https://github.com/microsoft/terminal/pull/9734 **State:** closed **Merged:** Yes --- Reduce instances of font fallback dialog through package font loading, basic name trimming, and revised fallback test - Adjusts the font dialog to only show when we attempt last-chance resolution from our hardcoded list of font names with a flag instead of with a string comparison by name - Adds a resolution step to trim the font name by word from the end and retry to attempt to resolve a proper font that just has a weight suffix - Adds a second font collection to font loading that will attempt to locate all TTF files sitting next to our binary, like in our package - [x] Wrote my font preference in the JSON as `Cascadia Code Heavy` and watched it quietly resolve to just `Cascadia Code` without the dialog. - [x] Put a font that isn't registered with the system into the layout directory for the package, set it as my desired font in Terminal, and watched it load just fine. - [x] Try a font name with different casing and see if dialog doesn't pop anymore - [x] Try a font with different (localized) names like MS ゴシック and see if dialog doesn't pop anymore - [x] Check Win7 with WPF target Closes #9375
claunia added the pull-request label 2026-01-31 09:23:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27725