starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9772] [MERGED] Remove unused methods in ConGetSet and SCREEN_INFORMATION #27729

New Issue
Open
opened 2026-01-31 09:23:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:23:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9772
Author: @j4james
Created: 4/11/2021
Status: ✅ Merged
Merged: 4/12/2021
Merged by: @undefined

Base: main ← Head: nuke-unused-methods

📝 Commits (3)

  • cb5be92 Remove unused GetScrollingRegion method.
  • 3cc5c9c Remove unused Get/SetConsoleCursorInfo methods.
  • d1740c7 Remove Get/SetConsoleCursorInfo from adapter test.

📊 Changes

6 files changed (+0 additions, -92 deletions)

View changed files

📝 src/host/outputStream.cpp (+0 -29)
📝 src/host/outputStream.hpp (+0 -3)
📝 src/host/screenInfo.cpp (+0 -20)
📝 src/host/screenInfo.hpp (+0 -1)
📝 src/terminal/adapter/conGetSet.hpp (+0 -2)
📝 src/terminal/adapter/ut_adapter/adapterTest.cpp (+0 -37)

📄 Description

This PR removes the GetConsoleCursorInfo and SetConsoleCursorInfo
methods from the ConGetSet interface, and the GetScrollingRegion
method from the SCREEN_INFORMATION class. None of these methods are
used anymore.

PR #2764 removed the last usage of GetScrollingRegion.

The Get/SetConsoleCursorInfo methods don't seem to have ever been used
in the time that the terminal code has been open source, so whatever
purpose they originally served must have been replaced a long time ago.

The GetScrollingRegion method was originally called from the
ScrollRegion function, but that usage was removed in PR #2764 when the
margin handling was moved to a higher level.

I've checked that the code still compiles.

Closes #9771

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9772 **Author:** [@j4james](https://github.com/j4james) **Created:** 4/11/2021 **Status:** ✅ Merged **Merged:** 4/12/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `nuke-unused-methods` --- ### 📝 Commits (3) - [`cb5be92`](https://github.com/microsoft/terminal/commit/cb5be924643a2aa8468d682e0a37d852a36f766d) Remove unused GetScrollingRegion method. - [`3cc5c9c`](https://github.com/microsoft/terminal/commit/3cc5c9cd311b9a382ad1020a9bcc064c20a6974c) Remove unused Get/SetConsoleCursorInfo methods. - [`d1740c7`](https://github.com/microsoft/terminal/commit/d1740c745d160a32aca993e5a3cecc8f566ff4c9) Remove Get/SetConsoleCursorInfo from adapter test. ### 📊 Changes **6 files changed** (+0 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `src/host/outputStream.cpp` (+0 -29) 📝 `src/host/outputStream.hpp` (+0 -3) 📝 `src/host/screenInfo.cpp` (+0 -20) 📝 `src/host/screenInfo.hpp` (+0 -1) 📝 `src/terminal/adapter/conGetSet.hpp` (+0 -2) 📝 `src/terminal/adapter/ut_adapter/adapterTest.cpp` (+0 -37) </details> ### 📄 Description This PR removes the `GetConsoleCursorInfo` and `SetConsoleCursorInfo` methods from the `ConGetSet` interface, and the `GetScrollingRegion` method from the `SCREEN_INFORMATION` class. None of these methods are used anymore. PR #2764 removed the last usage of `GetScrollingRegion`. The `Get/SetConsoleCursorInfo` methods don't seem to have ever been used in the time that the terminal code has been open source, so whatever purpose they originally served must have been replaced a long time ago. The `GetScrollingRegion` method was originally called from the `ScrollRegion` function, but that usage was removed in PR #2764 when the margin handling was moved to a higher level. I've checked that the code still compiles. Closes #9771 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:23:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27729
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?