starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #9783] [MERGED] Add support for the win key in keybindings #27738

New Issue
Open
opened 2026-01-31 09:23:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:23:56 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9783
Author: @zadjii-msft
Created: 4/12/2021
Status: ✅ Merged
Merged: 4/15/2021
Merged by: @undefined

Base: main ← Head: dev/migrie/f/win-in-keybindings

📝 Commits (5)

  • 10ea533 Add support for the win key in keybindings
  • 26ba407 This actually allows win to be used successfully in a keybinding
  • 5eb94ac Merge remote-tracking branch 'origin/main' into dev/migrie/f/win-in-keybindings
  • 4cfc4c2 Use the regex from @miniksa, though I'm not sure vscode supports the negative look behind at all
  • 158ace3 The last stragglers of this PR

📊 Changes

9 files changed (+59 additions, -6 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -2)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+5 -0)
📝 src/cascadia/TerminalControl/KeyChord.cpp (+9 -0)
📝 src/cascadia/TerminalControl/KeyChord.h (+1 -0)
📝 src/cascadia/TerminalControl/KeyChord.idl (+3 -1)
📝 src/cascadia/TerminalControl/TermControl.cpp (+4 -1)
📝 src/cascadia/TerminalCore/ControlKeyStates.hpp (+20 -1)
📝 src/cascadia/TerminalSettingsModel/KeyChordSerialization.cpp (+11 -1)
📝 src/cascadia/TerminalSettingsModel/KeyMapping.cpp (+4 -0)

📄 Description

Summary of the Pull Request

Does what it says on the can. People can now use win in a keybinding to
indicate that the chord needs win.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

For the record, I hate this. But it's great for quake mode, so meh. There's
shockingly more win keys claimed then you think - many more than the shortcut
guide even shows.

  • win+b: Focus the tray?
  • win+t: Focus the taskbar
  • win+p: Project...
  • win+c: The powertoys color picker
  • win+v: cloud clipboard

So the list of valid combos is vanishingly small. It's all about that win+~

Validation Steps Performed

Bound

        { "keys": [ "win+`" ], "command": "commandPalette" },

and yea, it works as expected

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9783 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/12/2021 **Status:** ✅ Merged **Merged:** 4/15/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/f/win-in-keybindings` --- ### 📝 Commits (5) - [`10ea533`](https://github.com/microsoft/terminal/commit/10ea53330579f0222d9cd0417aafbf62b2d52404) Add support for the `win` key in keybindings - [`26ba407`](https://github.com/microsoft/terminal/commit/26ba40779a658ea2509fcd07bb021ed8e03a870e) This actually allows `win` to be used successfully in a keybinding - [`5eb94ac`](https://github.com/microsoft/terminal/commit/5eb94ac393db9684fb74e56b795b9e619cb98a91) Merge remote-tracking branch 'origin/main' into dev/migrie/f/win-in-keybindings - [`4cfc4c2`](https://github.com/microsoft/terminal/commit/4cfc4c2bab4840ee7257fe424f26f43f1c43d330) Use the regex from @miniksa, though I'm not sure vscode supports the negative look behind at all - [`158ace3`](https://github.com/microsoft/terminal/commit/158ace37b1af04d99d330e00a09b1aabc4a5756d) The last stragglers of this PR ### 📊 Changes **9 files changed** (+59 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -2) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+5 -0) 📝 `src/cascadia/TerminalControl/KeyChord.cpp` (+9 -0) 📝 `src/cascadia/TerminalControl/KeyChord.h` (+1 -0) 📝 `src/cascadia/TerminalControl/KeyChord.idl` (+3 -1) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+4 -1) 📝 `src/cascadia/TerminalCore/ControlKeyStates.hpp` (+20 -1) 📝 `src/cascadia/TerminalSettingsModel/KeyChordSerialization.cpp` (+11 -1) 📝 `src/cascadia/TerminalSettingsModel/KeyMapping.cpp` (+4 -0) </details> ### 📄 Description ## Summary of the Pull Request Does what it says on the can. People can now use `win` in a keybinding to indicate that the chord needs <kbd>win</kbd>. ## References * Done for #653 * See also #8888 ## PR Checklist * [x] Closes #3184 * [x] I work here * [ ] Tests added/passed * [ ] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments For the record, I hate this. But it's great for quake mode, so _meh_. There's shockingly more win keys claimed then you think - many more than the shortcut guide even shows. * `win+b`: Focus the tray? * `win+t`: Focus the taskbar * `win+p`: Project... * `win+c`: The powertoys color picker * `win+v`: cloud clipboard So the list of valid combos is vanishingly small. It's all about that <kbd>win+~</kbd> ## Validation Steps Performed Bound ```json { "keys": [ "win+`" ], "command": "commandPalette" }, ``` and yea, it works as expected --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:23:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27738
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?