[PR #9801] [MERGED] Add names to threads to make debugging a slight bit easier #27760

Open
opened 2026-01-31 09:24:05 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9801
Author: @miniksa
Created: 4/13/2021
Status: ✅ Merged
Merged: 4/14/2021
Merged by: @undefined

Base: main ← Head: dev/miniksa/thread_naming


📝 Commits (1)

  • 6195474 Add names to threads to make debugging a slight bit easier.

📊 Changes

7 files changed (+9 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalConnection/AzureConnection.cpp (+2 -0)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+2 -0)
📝 src/host/PtySignalInputThread.cpp (+1 -0)
📝 src/host/VtInputThread.cpp (+1 -0)
📝 src/host/srvinit.cpp (+1 -0)
📝 src/interactivity/win32/ConsoleInputThread.cpp (+1 -0)
📝 src/renderer/base/thread.cpp (+1 -0)

📄 Description

Add names to threads to make debugging a slight bit easier.

PR Checklist

  • Closes personal todo item.
  • I work here.
  • Tested manually.

Detailed Description of the Pull Request / Additional comments

Thread descriptions show up as names in both the Visual Studio debugger, WinDBG debugger, and Windows Performance Analyzer. This makes it faster and easier to identify threads of interest in our processes.

Validation Steps Performed

  • Checked threads were named in OpenConsole.exe running in classic conhost window mode under VS debug
  • Checked threads were named in OpenConsole.exe running in conpty mode under VS debug
  • Checked threads were named in WindowsTerminal.exe (for a few of the threads around connections)
  • Checked that we could also see it in WinDBG

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9801 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 4/13/2021 **Status:** ✅ Merged **Merged:** 4/14/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/miniksa/thread_naming` --- ### 📝 Commits (1) - [`6195474`](https://github.com/microsoft/terminal/commit/619547486c8b0832750f69f0f32a8b7eb8c2434a) Add names to threads to make debugging a slight bit easier. ### 📊 Changes **7 files changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalConnection/AzureConnection.cpp` (+2 -0) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+2 -0) 📝 `src/host/PtySignalInputThread.cpp` (+1 -0) 📝 `src/host/VtInputThread.cpp` (+1 -0) 📝 `src/host/srvinit.cpp` (+1 -0) 📝 `src/interactivity/win32/ConsoleInputThread.cpp` (+1 -0) 📝 `src/renderer/base/thread.cpp` (+1 -0) </details> ### 📄 Description Add names to threads to make debugging a slight bit easier. ## PR Checklist * [x] Closes personal todo item. * [x] I work here. * [x] Tested manually. ## Detailed Description of the Pull Request / Additional comments Thread descriptions show up as names in both the Visual Studio debugger, WinDBG debugger, and Windows Performance Analyzer. This makes it faster and easier to identify threads of interest in our processes. ## Validation Steps Performed * [x] Checked threads were named in OpenConsole.exe running in classic conhost window mode under VS debug * [x] Checked threads were named in OpenConsole.exe running in conpty mode under VS debug * [x] Checked threads were named in WindowsTerminal.exe (for a few of the threads around connections) * [x] Checked that we could also see it in WinDBG --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:24:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27760