[PR #9807] [MERGED] Make whitespace trimming in block selection configurable #27762

Open
opened 2026-01-31 09:24:05 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9807
Author: @Don-Vito
Created: 4/14/2021
Status: ✅ Merged
Merged: 4/23/2021
Merged by: @undefined

Base: main ← Head: 9706-trim-block-selection


📝 Commits (4)

  • 24b0939 Make whitespace trimming in block selection configurable
  • 3d606b2 Add trimBlockSelection setting to the schema
  • 16e381f Fix typo
  • 6e50ab3 Update src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw

📊 Changes

14 files changed (+38 additions, -9 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+5 -0)
📝 src/cascadia/TerminalCore/ICoreSettings.idl (+1 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+3 -1)
📝 src/cascadia/TerminalCore/Terminal.hpp (+1 -0)
📝 src/cascadia/TerminalCore/TerminalSelection.cpp (+6 -7)
📝 src/cascadia/TerminalSettingsEditor/Interaction.xaml (+5 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+5 -1)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp (+5 -0)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl (+1 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+1 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/defaults.json (+1 -0)
📝 src/cascadia/UnitTests_TerminalCore/MockTermSettings.h (+2 -0)

📄 Description

PR Checklist

Detailed Description of the Pull Request / Additional comments

Added global flag named trimBlockSelection set to false by default.
The setting was added to Interactions menu of the SUI.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9807 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 4/14/2021 **Status:** ✅ Merged **Merged:** 4/23/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `9706-trim-block-selection` --- ### 📝 Commits (4) - [`24b0939`](https://github.com/microsoft/terminal/commit/24b09396e13d24accdef27ca1d7faadcd5a1da2b) Make whitespace trimming in block selection configurable - [`3d606b2`](https://github.com/microsoft/terminal/commit/3d606b2012ca3a60e9e4262295b7b7c3ab11eaf6) Add trimBlockSelection setting to the schema - [`16e381f`](https://github.com/microsoft/terminal/commit/16e381fe98df917e5a098a63abcd72b319568ff2) Fix typo - [`6e50ab3`](https://github.com/microsoft/terminal/commit/6e50ab3a4614a128e24f307308c31be9790611da) Update src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw ### 📊 Changes **14 files changed** (+38 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+5 -0) 📝 `src/cascadia/TerminalCore/ICoreSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+3 -1) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+1 -0) 📝 `src/cascadia/TerminalCore/TerminalSelection.cpp` (+6 -7) 📝 `src/cascadia/TerminalSettingsEditor/Interaction.xaml` (+5 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+5 -1) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp` (+5 -0) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/defaults.json` (+1 -0) 📝 `src/cascadia/UnitTests_TerminalCore/MockTermSettings.h` (+2 -0) </details> ### 📄 Description ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/issues/9706 * [x] CLA signed. * [ ] Tests added/passed * [x] Documentation updated here: https://github.com/MicrosoftDocs/terminal/pull/313 * [x] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments Added global flag named `trimBlockSelection` set to `false` by default. The setting was added to Interactions menu of the SUI. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:24:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27762