[PR #9815] [MERGED] Fix the renamer tests #27772

Open
opened 2026-01-31 09:24:09 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9815
Author: @zadjii-msft
Created: 4/14/2021
Status: ✅ Merged
Merged: 4/14/2021
Merged by: @undefined

Base: main ← Head: dev/migrie/b/9769-renamer-tests


📝 Commits (1)

📊 Changes

2 files changed (+14 additions, -2 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/TabTests.cpp (+8 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+6 -2)

📄 Description

Summary of the Pull Request

Clearly, I didn't run these tests on my last commit where I made the toasts lazy-load.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

For whatever reason, these tests are unhappy running back to back, but are just fine running isolated.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9815 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/14/2021 **Status:** ✅ Merged **Merged:** 4/14/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/9769-renamer-tests` --- ### 📝 Commits (1) - [`3a40565`](https://github.com/microsoft/terminal/commit/3a40565b9d2cc53a133f2c329b2fe9b37d298c6b) Fix the tests ### 📊 Changes **2 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/TabTests.cpp` (+8 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+6 -2) </details> ### 📄 Description ## Summary of the Pull Request Clearly, I didn't run these tests on my last commit where I made the toasts lazy-load. ## References * broken in in #9662 * ## PR Checklist * [x] Closes #9769 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments For whatever reason, these tests are unhappy running back to back, but are just fine running isolated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:24:09 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27772