[PR #9953] [MERGED] Remove bug fixes which aren't needed in VS 16.9 #27822

Open
opened 2026-01-31 09:24:29 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/9953
Author: @lhecker
Created: 4/26/2021
Status: Merged
Merged: 4/28/2021
Merged by: @undefined

Base: mainHead: dev/lhecker/vs-fix-cleanup


📝 Commits (2)

  • 5ec369a Remove bug fixes which aren't needed in VS 16.9
  • f7a606c Remove invalid file references from project files

📊 Changes

11 files changed (+14 additions, -55 deletions)

View changed files

📝 src/cascadia/CascadiaPackage/CascadiaPackage.wapproj (+0 -4)
📝 src/cascadia/Remoting/dll/Microsoft.Terminal.Remoting.vcxproj (+0 -1)
src/cascadia/TerminalApp/dll/FixVisualStudioBug.targets (+0 -30)
📝 src/cascadia/TerminalApp/dll/TerminalApp.vcxproj (+0 -4)
📝 src/cascadia/TerminalControl/dll/TerminalControl.vcxproj (+0 -1)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+0 -1)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters (+4 -2)
📝 src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj (+0 -1)
📝 src/cascadia/WinRTUtils/WinRTUtils.vcxproj (+5 -4)
📝 src/cascadia/WinRTUtils/WinRTUtils.vcxproj.filters (+5 -3)
📝 src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj (+0 -4)

📄 Description

Summary of the Pull Request

I came across a few build system bug fixes, which served their purpose now that VS 16.9 has been released.

PR Checklist

  • I work here
  • Project still compiles

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/9953 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 4/26/2021 **Status:** ✅ Merged **Merged:** 4/28/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/vs-fix-cleanup` --- ### 📝 Commits (2) - [`5ec369a`](https://github.com/microsoft/terminal/commit/5ec369a8b871584de617d59e1c6e2fa40c83a59e) Remove bug fixes which aren't needed in VS 16.9 - [`f7a606c`](https://github.com/microsoft/terminal/commit/f7a606c08bcc4e701a315a34ec67ed1a4beeb3c6) Remove invalid file references from project files ### 📊 Changes **11 files changed** (+14 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/CascadiaPackage/CascadiaPackage.wapproj` (+0 -4) 📝 `src/cascadia/Remoting/dll/Microsoft.Terminal.Remoting.vcxproj` (+0 -1) ➖ `src/cascadia/TerminalApp/dll/FixVisualStudioBug.targets` (+0 -30) 📝 `src/cascadia/TerminalApp/dll/TerminalApp.vcxproj` (+0 -4) 📝 `src/cascadia/TerminalControl/dll/TerminalControl.vcxproj` (+0 -1) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+0 -1) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters` (+4 -2) 📝 `src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj` (+0 -1) 📝 `src/cascadia/WinRTUtils/WinRTUtils.vcxproj` (+5 -4) 📝 `src/cascadia/WinRTUtils/WinRTUtils.vcxproj.filters` (+5 -3) 📝 `src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj` (+0 -4) </details> ### 📄 Description ## Summary of the Pull Request I came across a few build system bug fixes, which served their purpose now that VS 16.9 has been released. ## PR Checklist * [x] I work here * [x] Project still compiles --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:24:29 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27822