starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10022] [MERGED] Add a setting to disable URL detection #27851

New Issue
Open
opened 2026-01-31 09:24:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:24:39 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10022
Author: @PankajBhojwani
Created: 5/3/2021
Status: ✅ Merged
Merged: 5/17/2021
Merged by: @undefined

Base: main ← Head: dev/pabhoj/disable_link

📝 Commits (10+)

📊 Changes

16 files changed (+58 additions, -8 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+5 -0)
📝 src/buffer/out/textBuffer.cpp (+8 -0)
📝 src/buffer/out/textBuffer.hpp (+1 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+2 -1)
📝 src/cascadia/TerminalCore/ICoreSettings.idl (+1 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+18 -6)
📝 src/cascadia/TerminalCore/Terminal.hpp (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/Interaction.xaml (+5 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+4 -0)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp (+5 -0)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl (+1 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+1 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+1 -0)
📝 src/cascadia/UnitTests_Control/MockControlSettings.h (+1 -0)
📝 src/cascadia/UnitTests_TerminalCore/MockTermSettings.h (+2 -0)

📄 Description

Summary of the Pull Request

Adds a global setting, experimental.detectHyperlinks, that controls whether we automatically detect links and make them clickable. Default is set to true.

PR Checklist

  • Closes Start a tab as admin (#9981)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

When detectHyperlinks is set to false, links do not underline on hover and are not clickable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10022 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 5/3/2021 **Status:** ✅ Merged **Merged:** 5/17/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/disable_link` --- ### 📝 Commits (10+) - [`66a9faf`](https://github.com/microsoft/terminal/commit/66a9faf828c1284ebf6a4e6f4bd6907f33bbfe57) setting to disable link detection - [`caa88d6`](https://github.com/microsoft/terminal/commit/caa88d616700cc9aa26a6a5e4b875bc80ce6b8f8) hot reload 1 - [`f1c68c2`](https://github.com/microsoft/terminal/commit/f1c68c230eca9889460dfe4d9a22930ef20adf9a) experimental, hot reload - [`b8f3f87`](https://github.com/microsoft/terminal/commit/b8f3f87a7540138e4eae8ea65f9c2f8e7203a87e) undo hot reload for now, requires more thought than I realized - [`407171b`](https://github.com/microsoft/terminal/commit/407171b114bba7bafdfef151abe04f9c4cd6ce9d) don't need clear without hot reload - [`010a824`](https://github.com/microsoft/terminal/commit/010a824a687b2817585697ad59968189712d640c) ok no not that bad - [`dbc138d`](https://github.com/microsoft/terminal/commit/dbc138d45185d190910a72e28489854689537d44) conflict - [`dcbc767`](https://github.com/microsoft/terminal/commit/dcbc767d1ea7ec41cc054c549497ed8ef8468f5c) unpack - [`e235679`](https://github.com/microsoft/terminal/commit/e2356791b352c9628575b19336325be47dc7f5cc) clear and reload - [`3ff2b97`](https://github.com/microsoft/terminal/commit/3ff2b971038ecf12d08dba59369cd9d86f9d286b) rename ### 📊 Changes **16 files changed** (+58 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+5 -0) 📝 `src/buffer/out/textBuffer.cpp` (+8 -0) 📝 `src/buffer/out/textBuffer.hpp` (+1 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+2 -1) 📝 `src/cascadia/TerminalCore/ICoreSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+18 -6) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/Interaction.xaml` (+5 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+4 -0) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp` (+5 -0) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+1 -0) 📝 `src/cascadia/UnitTests_Control/MockControlSettings.h` (+1 -0) 📝 `src/cascadia/UnitTests_TerminalCore/MockTermSettings.h` (+2 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds a global setting, `experimental.detectHyperlinks`, that controls whether we automatically detect links and make them clickable. Default is set to true. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #9981 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [x] Schema updated. * [x] I work here <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed When `detectHyperlinks` is set to false, links do not underline on hover and are not clickable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:24:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27851
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?