[PR #10108] [MERGED] This fixes summoning _quake as the MRU window #27895

Open
opened 2026-01-31 09:24:57 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10108
Author: @zadjii-msft
Created: 5/17/2021
Status: Merged
Merged: 5/19/2021
Merged by: @DHowett

Base: mainHead: dev/migrie/b/fix-summon-mru-quake


📝 Commits (3)

  • 37a96d6 This fixes summoning _quake as the MRU window
  • d31a17a Merge remote-tracking branch 'origin/main' into dev/migrie/b/fix-summon-mru-quake
  • 48c6927 doc comments

📊 Changes

3 files changed (+154 additions, -16 deletions)

View changed files

📝 src/cascadia/Remoting/Monarch.cpp (+12 -5)
📝 src/cascadia/Remoting/Monarch.h (+1 -1)
📝 src/cascadia/UnitTests_Remoting/RemotingTests.cpp (+141 -10)

📄 Description

Summary of the Pull Request

This fixes a bug where if you had the _quake window open, and you tried to globalSummon it (not with the quakeMode action, but just with a plain-old globalSummon to activate the MRU window), we'd create a new window instead of just summoning the _quake window.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

It's basically a one-line fix, I just had to update the function signature for _getMostRecentPeasantID to allow us to use it differently for glomming vs summoning. When glomming, ignoreQuakeWindow should be true. When summoning, ignoreQuakeWindow should be false.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10108 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/17/2021 **Status:** ✅ Merged **Merged:** 5/19/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/migrie/b/fix-summon-mru-quake` --- ### 📝 Commits (3) - [`37a96d6`](https://github.com/microsoft/terminal/commit/37a96d6306f2b7cbd1e892e9cf693b3c917fa108) This fixes summoning _quake as the MRU window - [`d31a17a`](https://github.com/microsoft/terminal/commit/d31a17acc15cd0732170d368995c264358e9d283) Merge remote-tracking branch 'origin/main' into dev/migrie/b/fix-summon-mru-quake - [`48c6927`](https://github.com/microsoft/terminal/commit/48c6927396712530e3082c72e9472dd1bf0e6e71) doc comments ### 📊 Changes **3 files changed** (+154 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/Remoting/Monarch.cpp` (+12 -5) 📝 `src/cascadia/Remoting/Monarch.h` (+1 -1) 📝 `src/cascadia/UnitTests_Remoting/RemotingTests.cpp` (+141 -10) </details> ### 📄 Description ## Summary of the Pull Request This fixes a bug where if you had the `_quake` window open, and you tried to `globalSummon` it (not with the `quakeMode` action, but just with a plain-old `globalSummon` to activate the MRU window), we'd _create a new window_ instead of just summoning the `_quake` window. ## References * regressed in #9956 ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/projects/5#card-60325142 * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments It's basically a one-line fix, I just had to update the function signature for `_getMostRecentPeasantID` to allow us to use it differently for glomming vs summoning. When glomming, `ignoreQuakeWindow` should be true. When summoning, `ignoreQuakeWindow` should be false. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:24:57 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27895