[PR #10114] [MERGED] Don't yeet focus to the control when the tab renamer is opened #27899

Open
opened 2026-01-31 09:24:59 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10114
Author: @zadjii-msft
Created: 5/17/2021
Status: Merged
Merged: 5/18/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/10112-dont-yeet-focus-from-tab-renamer


📝 Commits (3)

  • 04020cf Don't yeet focus to the control when the tab renamer is opened
  • eae1596 const noexcept
  • 541420f HeaderRenamerTextBox() isn't const, thanks xaml

📊 Changes

4 files changed (+23 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/TabHeaderControl.cpp (+12 -0)
📝 src/cascadia/TerminalApp/TabHeaderControl.h (+2 -0)
📝 src/cascadia/TerminalApp/TabHeaderControl.idl (+2 -0)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+7 -1)

📄 Description

This is a hotfix to #10048. When the tab renamer is opened, we need to make sure to not immediately steal focus from it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10114 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/17/2021 **Status:** ✅ Merged **Merged:** 5/18/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/10112-dont-yeet-focus-from-tab-renamer` --- ### 📝 Commits (3) - [`04020cf`](https://github.com/microsoft/terminal/commit/04020cfd2e43f6876b4c5bf4e7a73bb5646a2807) Don't yeet focus to the control when the tab renamer is opened - [`eae1596`](https://github.com/microsoft/terminal/commit/eae1596142c41e5093b1d6e720527073f170e06d) const noexcept - [`541420f`](https://github.com/microsoft/terminal/commit/541420f8f170222dc689cdbff02a3ec08d6ba5e5) `HeaderRenamerTextBox()` isn't const, thanks xaml ### 📊 Changes **4 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TabHeaderControl.cpp` (+12 -0) 📝 `src/cascadia/TerminalApp/TabHeaderControl.h` (+2 -0) 📝 `src/cascadia/TerminalApp/TabHeaderControl.idl` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+7 -1) </details> ### 📄 Description This is a hotfix to #10048. When the tab renamer is opened, we need to make sure to not immediately steal focus from it. * [x] closes #10112 * [x] I work here * [x] tested manually --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:24:59 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27899