starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10124] [MERGED] Revert "Add the profile, page icons to the page headers (#10046)" #27908

New Issue
Open
opened 2026-01-31 09:25:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:25:05 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10124
Author: @carlos-zamora
Created: 5/18/2021
Status: ✅ Merged
Merged: 5/18/2021
Merged by: @DHowett

Base: main ← Head: dev/cazamor/revert-page-header-icons

📝 Commits (1)

  • f6d58b1 Revert "Add the profile, page icons to the page headers (#10046)"

📊 Changes

5 files changed (+20 additions, -76 deletions)

View changed files

📝 src/cascadia/TerminalApp/CommandPalette.xaml (+6 -13)
📝 src/cascadia/TerminalSettingsEditor/AddProfile.xaml (+3 -8)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+2 -6)
📝 src/cascadia/TerminalSettingsEditor/MainPage.xaml (+8 -49)
📝 src/cascadia/TerminalSettingsModel/IconPathConverter.cpp (+1 -0)

📄 Description

This reverts commit a3a2a4102d.

#10046 causes a crash on save. MainPage::UpdateSettings() is unable to update the navigation view's selected item due to an "incorrect parameter". This is particularly strange to see because #10046 only modifies the navigation view's header, not the menu items themselves. Reverting this change fixes that crash (verified).

Reopens #9694

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10124 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 5/18/2021 **Status:** ✅ Merged **Merged:** 5/18/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/cazamor/revert-page-header-icons` --- ### 📝 Commits (1) - [`f6d58b1`](https://github.com/microsoft/terminal/commit/f6d58b1f7e4d182c8acff74a3b26368665ee7978) Revert "Add the profile, page icons to the page headers (#10046)" ### 📊 Changes **5 files changed** (+20 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CommandPalette.xaml` (+6 -13) 📝 `src/cascadia/TerminalSettingsEditor/AddProfile.xaml` (+3 -8) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+2 -6) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.xaml` (+8 -49) 📝 `src/cascadia/TerminalSettingsModel/IconPathConverter.cpp` (+1 -0) </details> ### 📄 Description This reverts commit a3a2a4102dff785ac84f0d37397113fae3ef2033. #10046 causes a crash on save. `MainPage::UpdateSettings()` is unable to update the navigation view's selected item due to an "incorrect parameter". This is particularly strange to see because #10046 only modifies the navigation view's header, not the menu items themselves. Reverting this change fixes that crash (verified). Reopens #9694 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27908
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?