starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10219] [MERGED] Terminal color picker tweaks #27958

New Issue
Open
opened 2026-01-31 09:25:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:25:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10219
Author: @ghost
Created: 5/26/2021
Status: ✅ Merged
Merged: 6/10/2021
Merged by: @undefined

Base: main ← Head: terminal-color-picker-tweaks

📝 Commits (10+)

📊 Changes

7 files changed (+189 additions, -169 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.xaml (+3 -0)
📝 src/cascadia/TerminalApp/ColorPickupFlyout.cpp (+1 -1)
📝 src/cascadia/TerminalApp/ColorPickupFlyout.h (+1 -1)
📝 src/cascadia/TerminalApp/ColorPickupFlyout.xaml (+171 -161)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.cpp (+9 -2)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.h (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml (+3 -3)

📄 Description

The flyout wasn't very polished, so I did some adjustments.
It's all visual changes, functionality should be the same.

  • made the flyout use OverlayCornerRadius and 16px padding (to match WinUI 2.6)
  • changed ColorPicker to muxc:ColorPicker for new styles (the color schemes picker too)
  • changed "Custom" Button into a ToggleButton
    • no longer needs ellipsis - localization files should be updated
  • OK button was moved to the right and uses accent color
  • adjusted margins and padding
  • tweaked the color boxes to look like the ones in color schemes

collapsednew expandednew

Validation Steps Performed

  • Color picker in settings UI still works ✔️
  • Color picker for tabs still works ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10219 **Author:** [@ghost](https://github.com/ghost) **Created:** 5/26/2021 **Status:** ✅ Merged **Merged:** 6/10/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `terminal-color-picker-tweaks` --- ### 📝 Commits (10+) - [`270b57d`](https://github.com/microsoft/terminal/commit/270b57dde384a07635c41ac06613b4037e897be6) Update ColorPickupFlyout.xaml - [`bbaa0fa`](https://github.com/microsoft/terminal/commit/bbaa0fa08c7a8b9d07ad0595d59b803f113813e6) Use MUX ColorPicker - [`55fc8c6`](https://github.com/microsoft/terminal/commit/55fc8c60928ee48adb0c24ca5be91f3ff2789326) Update ColorSchemes.xaml - [`dd94a24`](https://github.com/microsoft/terminal/commit/dd94a241dab18e0da28baa4f68619605f3598260) Update ColorSchemes.cpp - [`26aa3ab`](https://github.com/microsoft/terminal/commit/26aa3ab08c6dc786b5cf87a5a4b4ada21a9bec09) Update ColorSchemes.h - [`c3ef187`](https://github.com/microsoft/terminal/commit/c3ef1879ca72b8fe5a831650cda4588664bcb9cd) Update ColorSchemes.cpp - [`61beafe`](https://github.com/microsoft/terminal/commit/61beafe41ddb9de1b900e003b42e513610f74b65) Fix namespace - [`eac61dd`](https://github.com/microsoft/terminal/commit/eac61ddd4ade23ae63f67e11312314bc926b85d4) Change namespace to MUX - [`b8266a4`](https://github.com/microsoft/terminal/commit/b8266a4ae64d06af75e341648f6be8ae5ce7a2ea) Flyout padding, formatting fix - [`2a21a68`](https://github.com/microsoft/terminal/commit/2a21a6814edad0826a500f51f3c8f38b416fd26f) Format fix ### 📊 Changes **7 files changed** (+189 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.xaml` (+3 -0) 📝 `src/cascadia/TerminalApp/ColorPickupFlyout.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/ColorPickupFlyout.h` (+1 -1) 📝 `src/cascadia/TerminalApp/ColorPickupFlyout.xaml` (+171 -161) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.cpp` (+9 -2) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml` (+3 -3) </details> ### 📄 Description The flyout wasn't very polished, so I did some adjustments. It's all visual changes, functionality should be the same. * made the flyout use OverlayCornerRadius and 16px padding (to match WinUI 2.6) * changed ColorPicker to muxc:ColorPicker for new styles (the color schemes picker too) * changed "Custom" Button into a ToggleButton * no longer needs ellipsis - localization files should be updated * OK button was moved to the right and uses accent color * adjusted margins and padding * tweaked the color boxes to _look_ like the ones in color schemes ![collapsednew](https://user-images.githubusercontent.com/84711285/119713282-33cfcf80-be6a-11eb-9ad9-d18a97b1058a.png) ![expandednew](https://user-images.githubusercontent.com/84711285/119713295-35999300-be6a-11eb-8423-c1c03526b23a.png) ## Validation Steps Performed * Color picker in settings UI still works ✔️ * Color picker for tabs still works ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27958
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?