[PR #10264] [MERGED] Enable winrt::make<> detection #27965

Open
opened 2026-01-31 09:25:26 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10264
Author: @DHowett
Created: 5/28/2021
Status: ✅ Merged
Merged: 6/1/2021
Merged by: @undefined

Base: main ← Head: dev/duhowett/winrtmake


📝 Commits (1)

  • 3154b3f Now that we are on 19041, enable winrt::make detection

📊 Changes

3 files changed (+2 additions, -9 deletions)

View changed files

📝 src/cascadia/Remoting/WindowManager.h (+1 -1)
📝 src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj (+0 -4)
📝 src/cppwinrt.build.pre.props (+1 -4)

📄 Description

C++/WinRT has a way to ensure that we use make<> instead of allocating
WinRT objects on the stack, but until 10.0.19041 the XAML compiler
generated code that violated that rule.

Because of how make detection is implemented, it must create a derived
type (and so WinRT implementation types can't be final).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10264 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 5/28/2021 **Status:** ✅ Merged **Merged:** 6/1/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/winrtmake` --- ### 📝 Commits (1) - [`3154b3f`](https://github.com/microsoft/terminal/commit/3154b3f3120cee054169c8fa04e54be9d5747848) Now that we are on 19041, enable winrt::make detection ### 📊 Changes **3 files changed** (+2 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/Remoting/WindowManager.h` (+1 -1) 📝 `src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj` (+0 -4) 📝 `src/cppwinrt.build.pre.props` (+1 -4) </details> ### 📄 Description C++/WinRT has a way to ensure that we use `make<>` instead of allocating WinRT objects on the stack, but until 10.0.19041 the XAML compiler generated code that violated that rule. Because of how make detection is implemented, it must create a derived type (and so WinRT implementation types can't be `final`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:26 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27965