[PR #10280] [MERGED] Update profiles schema to draft 2020-12 #27978

Open
opened 2026-01-31 09:25:30 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10280
Author: @ealap
Created: 5/30/2021
Status: Merged
Merged: 6/5/2021
Merged by: @carlos-zamora

Base: mainHead: main


📝 Commits (1)

  • dd21b15 Update profiles.schema.json

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+1 -1)

📄 Description

Update profiles schema to draft 2020-12 because as mentioned in https://github.com/microsoft/vscode/issues/98724#issuecomment-786502628, OpenAPI Specification 3.1 defines using JSON Schema 2020-12 and VS Code already has early implementation around it.

Basically, this just gets rid of the following error shown by VS Code when editing the settings.json file

Draft 2019-09 schemas are not yet fully supported.

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • Schema updated.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10280 **Author:** [@ealap](https://github.com/ealap) **Created:** 5/30/2021 **Status:** ✅ Merged **Merged:** 6/5/2021 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`dd21b15`](https://github.com/microsoft/terminal/commit/dd21b15c731b4c4e528662ad38afe7ad01f5b2c1) Update profiles.schema.json ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+1 -1) </details> ### 📄 Description Update profiles schema to draft 2020-12 because as mentioned in https://github.com/microsoft/vscode/issues/98724#issuecomment-786502628, OpenAPI Specification 3.1 defines using JSON Schema 2020-12 and VS Code already has early implementation around it. Basically, this just gets rid of the following error shown by VS Code when editing the settings.json file ``` Draft 2019-09 schemas are not yet fully supported. ``` ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Schema updated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27978