starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10317] [MERGED] Allow creating and editing unfocused appearances in the SUI #27989

New Issue
Open
opened 2026-01-31 09:25:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:25:35 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10317
Author: @PankajBhojwani
Created: 6/3/2021
Status: ✅ Merged
Merged: 7/14/2021
Merged by: @undefined

Base: main ← Head: dev/pabhoj/sui_unfocused_appearance

📝 Commits (10+)

📊 Changes

13 files changed (+258 additions, -4 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Appearances.cpp (+14 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+6 -3)
📝 src/cascadia/TerminalSettingsEditor/Profiles.cpp (+74 -1)
📝 src/cascadia/TerminalSettingsEditor/Profiles.h (+26 -0)
📝 src/cascadia/TerminalSettingsEditor/Profiles.idl (+10 -0)
📝 src/cascadia/TerminalSettingsEditor/Profiles.xaml (+79 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+12 -0)
📝 src/cascadia/TerminalSettingsModel/Profile.cpp (+21 -0)
📝 src/cascadia/TerminalSettingsModel/Profile.h (+3 -0)
📝 src/cascadia/TerminalSettingsModel/Profile.idl (+3 -0)
📝 src/features.xml (+7 -0)

📄 Description

Summary of the Pull Request

Adds unfocused appearance creation/configuration in the SUI

There is now an 'Unfocused Appearance' section at the bottom of the 'Appearance' tab in a profile. There is a '+' button to create an unfocused appearance if one does not exist, or a delete button to delete the unfocused appearance if one exists (only one of these buttons is visible at a time).

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

unfocusedSUI

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10317 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 6/3/2021 **Status:** ✅ Merged **Merged:** 7/14/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/sui_unfocused_appearance` --- ### 📝 Commits (10+) - [`b923b4b`](https://github.com/microsoft/terminal/commit/b923b4b14f4d830c219eaad68c867d0833708bac) initial - [`85a6392`](https://github.com/microsoft/terminal/commit/85a6392df4a7f9bd30a96986d89ef5c9c6da5f8c) hm - [`d750d56`](https://github.com/microsoft/terminal/commit/d750d56e723650094fa90d32aa26d02c0e142bd7) cursor shape/height mostly work - [`ad35c70`](https://github.com/microsoft/terminal/commit/ad35c70b1ed5ff5a23bfb048c45ba132834d2b02) remove navigated to - [`5920408`](https://github.com/microsoft/terminal/commit/5920408c659e82fc15e1ff5367864c878234fd1f) Color scheme ish - [`7eea902`](https://github.com/microsoft/terminal/commit/7eea902ae45a375f36d570d9661f444bc6df46c6) background image stuff ish - [`f5078b8`](https://github.com/microsoft/terminal/commit/f5078b8944433ab161c2678d876bd1efcd16bcf3) bg image - [`f6cf9dd`](https://github.com/microsoft/terminal/commit/f6cf9dd0f066ba0f6c27a911318a2ff39dcec611) Remove can delete appearance for now - [`0800d64`](https://github.com/microsoft/terminal/commit/0800d64195d3bdff7907d6b26865e9c833b5def1) format - [`81a8b8b`](https://github.com/microsoft/terminal/commit/81a8b8b3b8297dde964b5bc5778c8fe7de854c8f) dependency callback ### 📊 Changes **13 files changed** (+258 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Appearances.cpp` (+14 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+6 -3) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+74 -1) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.h` (+26 -0) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.idl` (+10 -0) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.xaml` (+79 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+12 -0) 📝 `src/cascadia/TerminalSettingsModel/Profile.cpp` (+21 -0) 📝 `src/cascadia/TerminalSettingsModel/Profile.h` (+3 -0) 📝 `src/cascadia/TerminalSettingsModel/Profile.idl` (+3 -0) 📝 `src/features.xml` (+7 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds unfocused appearance creation/configuration in the SUI There is now an 'Unfocused Appearance' section at the bottom of the 'Appearance' tab in a profile. There is a '+' button to create an unfocused appearance if one does not exist, or a delete button to delete the unfocused appearance if one exists (only one of these buttons is visible at a time). ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed ![unfocusedSUI](https://user-images.githubusercontent.com/26824113/125523613-48aefe28-b4cf-46a2-91c9-2ba3ea89e071.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#27989
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?