[PR #10384] [MERGED] profile.schema: add missing actions and commands keys #28016

Open
opened 2026-01-31 09:25:46 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10384
Author: @LuanVSO
Created: 6/9/2021
Status: ✅ Merged
Merged: 6/10/2021
Merged by: @carlos-zamora

Base: main ← Head: actions-schema


📝 Commits (10+)

📊 Changes

1 file changed (+96 additions, -5 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+96 -5)

📄 Description

Summary of the Pull Request

Add missing keys to the schema:

  • globalSummon (and args: desktop, monitor, name, dropdownDuration, toggleVisibility)
  • quakeMode
  • iterateOn
  • commands

Also enforces required keys for commands and deprecates "keybindings"

PR Checklist

Detailed Description of the Pull Request / Additional comments

There were some other pending keys mentioned on the issue, but I don't think they are pending anymore.

Validation Steps Performed

Changed the "$schema" value in my settings.json to point to the edited one.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10384 **Author:** [@LuanVSO](https://github.com/LuanVSO) **Created:** 6/9/2021 **Status:** ✅ Merged **Merged:** 6/10/2021 **Merged by:** [@carlos-zamora](https://github.com/carlos-zamora) **Base:** `main` ← **Head:** `actions-schema` --- ### 📝 Commits (10+) - [`49f92b6`](https://github.com/microsoft/terminal/commit/49f92b6ca088c8b5d879af251bcc506615b3b947) first shot at #gh7443 - [`b47b6c4`](https://github.com/microsoft/terminal/commit/b47b6c424b18b43622d58ffd74f402c7d2b090ba) commands needs at least 1 item - [`358be69`](https://github.com/microsoft/terminal/commit/358be69d29fc2d364588d2b846bdfae99e2b9692) formating - [`cba02ab`](https://github.com/microsoft/terminal/commit/cba02ab08ca3c4633435646fda5c97c7afc52a72) add object form of "name" - [`525dc5d`](https://github.com/microsoft/terminal/commit/525dc5dfb28d0202d2ec949890837624948f474a) add iterateon property - [`a6317c3`](https://github.com/microsoft/terminal/commit/a6317c3add817a60c0dcff3fd1eb070c1edcef7d) fix required properties - [`2e5bf8f`](https://github.com/microsoft/terminal/commit/2e5bf8f054e9a379031b404ebba90deb89260cfa) add globalsummon and quakemode actions - [`f718215`](https://github.com/microsoft/terminal/commit/f718215a4a280ca99d4edeec8b92c1ec0b16130c) oops wrong description - [`3286d0a`](https://github.com/microsoft/terminal/commit/3286d0a214768a604d77ca2d6f2508b108a36769) update descriptions - [`9af28cb`](https://github.com/microsoft/terminal/commit/9af28cb4ca904b94ce25b8712697c26899d74aaa) formatting ### 📊 Changes **1 file changed** (+96 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+96 -5) </details> ### 📄 Description ## Summary of the Pull Request Add missing keys to the schema: - globalSummon (and args: desktop, monitor, name, dropdownDuration, toggleVisibility) - quakeMode - iterateOn - commands Also enforces required keys for commands and deprecates "keybindings" ## PR Checklist * [x] Closes #7443 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Schema updated. ## Detailed Description of the Pull Request / Additional comments There were some other pending keys mentioned on the issue, but I don't think they are pending anymore. ## Validation Steps Performed Changed the `"$schema"` value in my settings.json to point to the edited one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:46 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28016