[PR #10389] [MERGED] Activate window only (no toggle) when inbound connection arrives #28017

Open
opened 2026-01-31 09:25:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10389
Author: @miniksa
Created: 6/9/2021
Status: ✅ Merged
Merged: 6/10/2021
Merged by: @undefined

Base: main ← Head: dev/miniksa/def_toggle


📝 Commits (1)

  • 389afd7 Do not toggle visibility when an inbound connection arrives. Just make visible if not.

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/AppHost.cpp (+1 -0)

📄 Description

Activate window only (no toggle) when inbound connection arrives

PR Checklist

Detailed Description of the Pull Request / Additional comments

The default for the SummonWindowBehavior is a toggle of the visibility state. I didn't realize that. We do not want that for inbound connections. We want always-brought-to-front.

Validation Steps Performed

  • Made the change. Launched Terminal as default as active window. Runbox'd another command. It didn't hide itself like it used to. Stays visible.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10389 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 6/9/2021 **Status:** ✅ Merged **Merged:** 6/10/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/miniksa/def_toggle` --- ### 📝 Commits (1) - [`389afd7`](https://github.com/microsoft/terminal/commit/389afd7e011b3831f3b9fc075e0a12fb346ccb96) Do not toggle visibility when an inbound connection arrives. Just make visible if not. ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+1 -0) </details> ### 📄 Description Activate window only (no toggle) when inbound connection arrives ## PR Checklist * [x] Closes #10386 * [x] I work here * [x] Manual test passed. ## Detailed Description of the Pull Request / Additional comments The default for the `SummonWindowBehavior` is a toggle of the visibility state. I didn't realize that. We do not want that for inbound connections. We want always-brought-to-front. ## Validation Steps Performed - Made the change. Launched Terminal as default as active window. Runbox'd another command. It didn't hide itself like it used to. Stays visible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:47 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28017