starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10401] [CLOSED] Make sure caption controls "dim out" when window loses NC focus #28026

New Issue
Open
opened 2026-01-31 09:25:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:25:50 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10401
Author: @AnuthaDev
Created: 6/10/2021
Status: ❌ Closed

Base: main ← Head: focused

📝 Commits (3)

📊 Changes

8 files changed (+81 additions, -1 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+1 -0)
📝 src/cascadia/TerminalApp/MinMaxCloseControl.cpp (+12 -0)
📝 src/cascadia/TerminalApp/MinMaxCloseControl.xaml (+16 -0)
📝 src/cascadia/TerminalApp/TitlebarControl.cpp (+13 -0)
📝 src/cascadia/TerminalApp/TitlebarControl.h (+4 -0)
📝 src/cascadia/TerminalApp/TitlebarControl.idl (+5 -1)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+28 -0)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.h (+2 -0)

📄 Description

Smol Code

Summary of the Pull Request

Make the caption controls "dim out" when window loses focus

References

https://docs.microsoft.com/en-us/windows/win32/winmsg/wm-ncactivate
https://github.com/microsoft/terminal/pull/5881
https://github.com/microsoft/terminal/pull/3025
#7015

PR Checklist

  • Applies to [VT Render] Investigate not breaking lines for node-pty (#1625)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Added a handler for WM_NCACTIVATE to propagate the focus change to the Titlebar Control.

The unfocused color is set to ForegroundBaseLow

Validation Steps Performed

None

(Potato™ PC, no compile)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10401 **Author:** [@AnuthaDev](https://github.com/AnuthaDev) **Created:** 6/10/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `focused` --- ### 📝 Commits (3) - [`5858150`](https://github.com/microsoft/terminal/commit/5858150d7d94e3eb0c17410d66879c478d97871e) Dim out window controls on lost focus - [`ca2f7e8`](https://github.com/microsoft/terminal/commit/ca2f7e83a2f559e0888f0801674bd6dd9b492f44) Fix diff - [`2ad9636`](https://github.com/microsoft/terminal/commit/2ad963647a904d0f79fb5b97a2361bf126fcab9b) Get rekt format bot ### 📊 Changes **8 files changed** (+81 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+1 -0) 📝 `src/cascadia/TerminalApp/MinMaxCloseControl.cpp` (+12 -0) 📝 `src/cascadia/TerminalApp/MinMaxCloseControl.xaml` (+16 -0) 📝 `src/cascadia/TerminalApp/TitlebarControl.cpp` (+13 -0) 📝 `src/cascadia/TerminalApp/TitlebarControl.h` (+4 -0) 📝 `src/cascadia/TerminalApp/TitlebarControl.idl` (+5 -1) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+28 -0) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.h` (+2 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> Smol Code ## Summary of the Pull Request <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> Make the caption controls "dim out" when window loses focus ## References https://docs.microsoft.com/en-us/windows/win32/winmsg/wm-ncactivate https://github.com/microsoft/terminal/pull/5881 https://github.com/microsoft/terminal/pull/3025 #7015 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Applies to #1625 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Added a handler for WM_NCACTIVATE to propagate the focus change to the Titlebar Control. The unfocused color is set to ForegroundBaseLow <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed None (Potato™ PC, no compile) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28026
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?