starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10404] [MERGED] Convert four INSIDE_WINDOWS blocks to til features #28036

New Issue
Open
opened 2026-01-31 09:25:54 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:25:54 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10404
Author: @DHowett
Created: 6/11/2021
Status: ✅ Merged
Merged: 6/11/2021
Merged by: @undefined

Base: main ← Head: dev/duhowett/jerkify

📝 Commits (5)

  • 4dcb4c5 Convert ReceiveIncomingHandoff from INSIDE_WINDOWS
  • 92bb96a Convert AttemptHandoff from INSIDE_WINDOWS
  • 911a3c6 Convert the DX engine from INSIDE_WINDOWS
  • 683b735 Convert numpad event synthesis from INSIDE_WINDOWS
  • 2ba97b0 spell: feature defines aren't checked

📊 Changes

12 files changed (+86 additions, -53 deletions)

View changed files

📝 .github/actions/spelling/patterns/patterns.txt (+1 -0)
📝 src/features.xml (+42 -3)
📝 src/host/exe/exemain.cpp (+3 -3)
📝 src/host/srvinit.cpp (+5 -5)
📝 src/host/ut_host/ClipboardTests.cpp (+23 -20)
📝 src/host/ut_host/VtIoTests.cpp (+3 -3)
📝 src/interactivity/base/EventSynthesis.cpp (+2 -12)
📝 src/interactivity/win32/window.cpp (+3 -3)
📝 src/renderer/dx/DxRenderer.cpp (+1 -1)
📝 src/renderer/dx/ScreenPixelShader.h (+1 -1)
📝 src/renderer/dx/ScreenVertexShader.h (+1 -1)
📝 src/server/IoDispatchers.cpp (+1 -1)

📄 Description

This pull request converts four of our existing #ifdef (or #ifndef)
INSIDE_WINDOWS blocks to til::features:

  • Attempting to establish a handoff session (inside Windows only)
  • The ability to receive a handoff session (outside Windows only)
  • The DX engine (outside Windows only) and shaders (also outside only)
  • Whether we use numpad event synthesis for clipboard/conpty (inside
    Windows only)

Most of these are using the preprocessor verison of til::feature, only
because it is more difficult to gate the inclusion of headers on
constant expressions. I'd love to prefer the compile time version.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10404 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 6/11/2021 **Status:** ✅ Merged **Merged:** 6/11/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/jerkify` --- ### 📝 Commits (5) - [`4dcb4c5`](https://github.com/microsoft/terminal/commit/4dcb4c56ba03246b278b67f5ca5bddaa058bac8d) Convert ReceiveIncomingHandoff from INSIDE_WINDOWS - [`92bb96a`](https://github.com/microsoft/terminal/commit/92bb96ad3a2f74d71c855146be90aec7e38c2094) Convert AttemptHandoff from INSIDE_WINDOWS - [`911a3c6`](https://github.com/microsoft/terminal/commit/911a3c64678f0842d971d58e9faafc5268594444) Convert the DX engine from INSIDE_WINDOWS - [`683b735`](https://github.com/microsoft/terminal/commit/683b735f3d8d68d6446baa0f2ebe7710d8f0ce93) Convert numpad event synthesis from INSIDE_WINDOWS - [`2ba97b0`](https://github.com/microsoft/terminal/commit/2ba97b0776a81a03dfa0ca4442a61ea770d761bc) spell: feature defines aren't checked ### 📊 Changes **12 files changed** (+86 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/patterns/patterns.txt` (+1 -0) 📝 `src/features.xml` (+42 -3) 📝 `src/host/exe/exemain.cpp` (+3 -3) 📝 `src/host/srvinit.cpp` (+5 -5) 📝 `src/host/ut_host/ClipboardTests.cpp` (+23 -20) 📝 `src/host/ut_host/VtIoTests.cpp` (+3 -3) 📝 `src/interactivity/base/EventSynthesis.cpp` (+2 -12) 📝 `src/interactivity/win32/window.cpp` (+3 -3) 📝 `src/renderer/dx/DxRenderer.cpp` (+1 -1) 📝 `src/renderer/dx/ScreenPixelShader.h` (+1 -1) 📝 `src/renderer/dx/ScreenVertexShader.h` (+1 -1) 📝 `src/server/IoDispatchers.cpp` (+1 -1) </details> ### 📄 Description This pull request converts four of our existing `#ifdef` (or `#ifndef`) `INSIDE_WINDOWS` blocks to til::features: * Attempting to establish a handoff session (inside Windows only) * The ability to *receive* a handoff session (outside Windows only) * The DX engine (outside Windows only) and shaders (also outside only) * Whether we use numpad event synthesis for clipboard/conpty (inside Windows only) Most of these are using the preprocessor verison of til::feature, only because it is more difficult to gate the inclusion of headers on constant expressions. I'd love to prefer the compile time version. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28036
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?