starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10426] [MERGED] Prefer FMT_COMPILE for string formatting in VtRenderer #28047

New Issue
Open
opened 2026-01-31 09:25:58 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:25:58 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10426
Author: @skyline75489
Created: 6/15/2021
Status: ✅ Merged
Merged: 6/22/2021
Merged by: @undefined

Base: main ← Head: chesterliu/dev/dirty-formatting

📝 Commits (10+)

📊 Changes

5 files changed (+35 additions, -112 deletions)

View changed files

📝 .github/actions/spelling/allow/microsoft.txt (+1 -0)
📝 src/host/ut_host/VtRendererTests.cpp (+5 -5)
📝 src/renderer/vt/VtSequences.cpp (+18 -40)
📝 src/renderer/vt/state.cpp (+1 -66)
📝 src/renderer/vt/vtrenderer.hpp (+10 -1)

📄 Description

Kill WriteFormattedString and replace it with fmt::format_to to avoid expensive string operations in VtRenderer.

This saves ~8% of the CPU time.

Inspired by https://github.com/microsoft/terminal/issues/10362#issuecomment-856625365

Co-authored-by: Leonard Hecker lhecker@microsoft.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10426 **Author:** [@skyline75489](https://github.com/skyline75489) **Created:** 6/15/2021 **Status:** ✅ Merged **Merged:** 6/22/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `chesterliu/dev/dirty-formatting` --- ### 📝 Commits (10+) - [`581c697`](https://github.com/microsoft/terminal/commit/581c69739dab6232050e5f9282e3cb1fa7f56efc) Draft implementation for fast string formatting - [`1ca22cd`](https://github.com/microsoft/terminal/commit/1ca22cd8d61b7515876c21e89fb18cd3a4df6d27) why not work - [`7231332`](https://github.com/microsoft/terminal/commit/7231332377db11c4d024a58c782179836cada5d6) OK now it works - [`d03136e`](https://github.com/microsoft/terminal/commit/d03136e90f26650c4f9ea46e44c631ccb53e87c2) Stack allocation only - [`f48e594`](https://github.com/microsoft/terminal/commit/f48e59427f5d0bce727df6f1cb340d25ebd52104) Use FMT_COMPILE - [`8b89940`](https://github.com/microsoft/terminal/commit/8b899407827e7c9421984c56fea33c18321b54f7) Code health - [`c677fbd`](https://github.com/microsoft/terminal/commit/c677fbd79b72ad323d61a537d10ce1db9a4f2587) small_vector - [`1321f05`](https://github.com/microsoft/terminal/commit/1321f05ab5226509a288ee10c5e250ec908f2fa5) Use std::back_insertor - [`88e8e0a`](https://github.com/microsoft/terminal/commit/88e8e0a3811f88de9c96b356acb53d12b6afaf08) Apply patch from Leonard - [`1043b61`](https://github.com/microsoft/terminal/commit/1043b61bf0cdb7ffb55caf5dee0f85a4bc62883f) Yeah this also works ### 📊 Changes **5 files changed** (+35 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/microsoft.txt` (+1 -0) 📝 `src/host/ut_host/VtRendererTests.cpp` (+5 -5) 📝 `src/renderer/vt/VtSequences.cpp` (+18 -40) 📝 `src/renderer/vt/state.cpp` (+1 -66) 📝 `src/renderer/vt/vtrenderer.hpp` (+10 -1) </details> ### 📄 Description Kill `WriteFormattedString` and replace it with `fmt::format_to` to avoid expensive string operations in VtRenderer. This saves ~8% of the CPU time. Inspired by https://github.com/microsoft/terminal/issues/10362#issuecomment-856625365 Co-authored-by: Leonard Hecker <lhecker@microsoft.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:25:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?