[PR #10494] [MERGED] Replicate winrt::make<> changes in ScratchIslandApp SampleAppLib #28078

Open
opened 2026-01-31 09:26:11 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10494
Author: @BreeceW
Created: 6/22/2021
Status: Merged
Merged: 6/23/2021
Merged by: @undefined

Base: mainHead: patch-1


📝 Commits (1)

  • c9e4252 Replicate winrt::make<> changes in ScratchIslandApp SampleAppLib

📊 Changes

1 file changed (+4 additions, -12 deletions)

View changed files

📝 scratch/ScratchIslandApp/SampleApp/App.base.h (+4 -12)

📄 Description

Sample scratch app would not compile. It does if we apply #10335 to App.base.h in the scratch app.

Closes #10493


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10494 **Author:** [@BreeceW](https://github.com/BreeceW) **Created:** 6/22/2021 **Status:** ✅ Merged **Merged:** 6/23/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`c9e4252`](https://github.com/microsoft/terminal/commit/c9e4252c4f33799640070323ebf2e57ddaf2539d) Replicate winrt::make<> changes in ScratchIslandApp SampleAppLib ### 📊 Changes **1 file changed** (+4 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `scratch/ScratchIslandApp/SampleApp/App.base.h` (+4 -12) </details> ### 📄 Description Sample scratch app would not compile. It does if we apply #10335 to App.base.h in the scratch app. Closes #10493 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:11 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28078