starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10513] [MERGED] Introduce a basic ApplicationState class #28088

New Issue
Open
opened 2026-01-31 09:26:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:26:14 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10513
Author: @lhecker
Created: 6/25/2021
Status: ✅ Merged
Merged: 6/30/2021
Merged by: @lhecker

Base: main ← Head: dev/lhecker/app-state

📝 Commits (4)

  • 7d45da3 Introduce a basic ApplicationState class
  • 48d12b5 Fix spell check
  • 2c12673 Fix formatting check
  • 08ef30b Address reviewer comments & improve docs

📊 Changes

12 files changed (+485 additions, -237 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+1 -2)
📝 doc/cascadia/AddASetting.md (+7 -7)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+30 -55)
📝 src/cascadia/TerminalApp/AppLogic.h (+8 -8)
➕ src/cascadia/TerminalSettingsModel/ApplicationState.cpp (+173 -0)
➕ src/cascadia/TerminalSettingsModel/ApplicationState.h (+69 -0)
➕ src/cascadia/TerminalSettingsModel/ApplicationState.idl (+13 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.h (+1 -2)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+26 -163)
➕ src/cascadia/TerminalSettingsModel/FileUtils.cpp (+137 -0)
➕ src/cascadia/TerminalSettingsModel/FileUtils.h (+11 -0)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj (+9 -0)

📄 Description

This commit introduces a basic ApplicationState class, without being used for anything yet to aid reviewers. At a later point actual usages of this new class may be added separately.

References

This commit is an initial step towards implementing #8324.

PR Checklist

  • I work here
  • Tests added/passed

Validation Steps Performed

  • Creating a state.json with {"generatedProfiles":["{53e75ed9-2b63-4118-856d-0510c4f6b97e}"]} updates the ApplicationState, as observed through a debugger ✔️
  • Deleting the "generatedProfiles" field sets the corresponding field back to nullopt ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10513 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 6/25/2021 **Status:** ✅ Merged **Merged:** 6/30/2021 **Merged by:** [@lhecker](https://github.com/lhecker) **Base:** `main` ← **Head:** `dev/lhecker/app-state` --- ### 📝 Commits (4) - [`7d45da3`](https://github.com/microsoft/terminal/commit/7d45da3b95f54f842549faac7b05b5674a03d999) Introduce a basic ApplicationState class - [`48d12b5`](https://github.com/microsoft/terminal/commit/48d12b543d3d1fe9a6c87165b6197d21330031c3) Fix spell check - [`2c12673`](https://github.com/microsoft/terminal/commit/2c12673d29f9433e3141d635ac17ae63c21aad46) Fix formatting check - [`08ef30b`](https://github.com/microsoft/terminal/commit/08ef30b0a14cb5f9ac915d36e8d9f72484763994) Address reviewer comments & improve docs ### 📊 Changes **12 files changed** (+485 additions, -237 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+1 -2) 📝 `doc/cascadia/AddASetting.md` (+7 -7) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+30 -55) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+8 -8) ➕ `src/cascadia/TerminalSettingsModel/ApplicationState.cpp` (+173 -0) ➕ `src/cascadia/TerminalSettingsModel/ApplicationState.h` (+69 -0) ➕ `src/cascadia/TerminalSettingsModel/ApplicationState.idl` (+13 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.h` (+1 -2) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+26 -163) ➕ `src/cascadia/TerminalSettingsModel/FileUtils.cpp` (+137 -0) ➕ `src/cascadia/TerminalSettingsModel/FileUtils.h` (+11 -0) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj` (+9 -0) </details> ### 📄 Description This commit introduces a basic ApplicationState class, without being used for anything yet to aid reviewers. At a later point actual usages of this new class may be added separately. ## References This commit is an initial step towards implementing #8324. ## PR Checklist * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * Creating a `state.json` with `{"generatedProfiles":["{53e75ed9-2b63-4118-856d-0510c4f6b97e}"]}` updates the ApplicationState, as observed through a debugger ✔️ * Deleting the "generatedProfiles" field sets the corresponding field back to nullopt ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28088
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?