starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10559] [MERGED] Introduce a api-ms-win-core-synch-l1-2-0 shim for Windows 7 #28105

New Issue
Open
opened 2026-01-31 09:26:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:26:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10559
Author: @lhecker
Created: 7/5/2021
Status: ✅ Merged
Merged: 7/7/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/api-ms-win-core-synch-l1-2-0

📝 Commits (6)

  • bb024d2 Introduce a api-ms-win-core-synch-l1-2-0 shim for Windows 7
  • fbe4516 Address reviewer comments
  • d48dae6 Address reviewer comments
  • 3c64393 Fix audit check
  • 07fd4cd Fix formatting check
  • 755d460 Fix formatting & add debug checks

📊 Changes

6 files changed (+320 additions, -12 deletions)

View changed files

📝 OpenConsole.sln (+47 -0)
➕ src/api-ms-win-core-synch-l1-2-0/api-ms-win-core-synch-l1-2-0.vcxproj (+27 -0)
➕ src/api-ms-win-core-synch-l1-2-0/api-ms-win-core-synch-l1-2-0.vcxproj.filters (+30 -0)
➕ src/api-ms-win-core-synch-l1-2-0/definitions.def (+19 -0)
➕ src/api-ms-win-core-synch-l1-2-0/main.cpp (+189 -0)
📝 src/cascadia/PublicTerminalCore/PublicTerminalCore.vcxproj (+8 -12)

📄 Description

The code in this file was adapted from the STL on the 2021-07-05.

It backports the following Windows 8 functions to Windows 7:

  • WaitOnAddress
  • WakeByAddressSingle
  • WakeByAddressAll

These functions are used within til. This commit will allow til to be used in the conhost source code.

Validation

  • correct .dll loads on Windows 7
  • correct .dll loads on Windows 10
  • link line for PublicTerminalCore prefers this fake apiset over kernel32

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10559 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 7/5/2021 **Status:** ✅ Merged **Merged:** 7/7/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/api-ms-win-core-synch-l1-2-0` --- ### 📝 Commits (6) - [`bb024d2`](https://github.com/microsoft/terminal/commit/bb024d2aa63aedfe69dfd363b828f346467c83a1) Introduce a api-ms-win-core-synch-l1-2-0 shim for Windows 7 - [`fbe4516`](https://github.com/microsoft/terminal/commit/fbe4516b838a46194830d7ddd89ae0988a5b9337) Address reviewer comments - [`d48dae6`](https://github.com/microsoft/terminal/commit/d48dae6f4bf50d6046205639d345eadf14ea85e1) Address reviewer comments - [`3c64393`](https://github.com/microsoft/terminal/commit/3c64393af2f66c8125d818c1f1c46da00706b90c) Fix audit check - [`07fd4cd`](https://github.com/microsoft/terminal/commit/07fd4cd5556aa14e10d0cd6767b7c9d178b44c40) Fix formatting check - [`755d460`](https://github.com/microsoft/terminal/commit/755d4600760c6ec13f6cbdd7183d639c22b2801e) Fix formatting & add debug checks ### 📊 Changes **6 files changed** (+320 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `OpenConsole.sln` (+47 -0) ➕ `src/api-ms-win-core-synch-l1-2-0/api-ms-win-core-synch-l1-2-0.vcxproj` (+27 -0) ➕ `src/api-ms-win-core-synch-l1-2-0/api-ms-win-core-synch-l1-2-0.vcxproj.filters` (+30 -0) ➕ `src/api-ms-win-core-synch-l1-2-0/definitions.def` (+19 -0) ➕ `src/api-ms-win-core-synch-l1-2-0/main.cpp` (+189 -0) 📝 `src/cascadia/PublicTerminalCore/PublicTerminalCore.vcxproj` (+8 -12) </details> ### 📄 Description The code in this file was adapted from the STL on the 2021-07-05. It backports the following Windows 8 functions to Windows 7: * WaitOnAddress * WakeByAddressSingle * WakeByAddressAll These functions are used within `til`. This commit will allow `til` to be used in the conhost source code. Validation * [x] correct .dll loads on Windows 7 * [x] correct .dll loads on Windows 10 * [x] link line for PublicTerminalCore prefers this fake apiset over kernel32 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28105
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?