starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10566] [MERGED] Use memcmp for TextAttribute & TextColor comparison #28108

New Issue
Open
opened 2026-01-31 09:26:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:26:24 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10566
Author: @skyline75489
Created: 7/6/2021
Status: ✅ Merged
Merged: 5/5/2022
Merged by: @undefined

Base: main ← Head: chesterliu/dev/text-colorrrr

📝 Commits (5)

  • e1c5726 Use memcmp for TextAttribute & TextColor comparison
  • ae4382e Missed one
  • e84eeae Nope, doesn't work
  • 149e967 Merge branch 'main' into chesterliu/dev/text-colorrrr
  • 5423de5 Merge branch 'main' into chesterliu/dev/text-colorrrr

📊 Changes

5 files changed (+29 additions, -37 deletions)

View changed files

📝 src/buffer/out/TextAttribute.cpp (+2 -0)
📝 src/buffer/out/TextAttribute.hpp (+10 -21)
📝 src/buffer/out/TextColor.cpp (+7 -0)
📝 src/buffer/out/TextColor.h (+9 -15)
📝 src/inc/conattrs.hpp (+1 -1)

📄 Description

TextAttribute and TextColor are commonly used structures in hot paths.
This commit replaces more complex comparisons where each field is compared
independently with a single call to memcmp. This compiles down to just
a few instructions. This reduces code and binary size and improves
performance for paths were TextAttributes need to be compared.

PR Checklist

  • Supports What about 'over all windows' as Task Manager? (#10563)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

  • termbench still works ✔️

Co-authored-by: Leonard Hecker lhecker@microsoft.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10566 **Author:** [@skyline75489](https://github.com/skyline75489) **Created:** 7/6/2021 **Status:** ✅ Merged **Merged:** 5/5/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `chesterliu/dev/text-colorrrr` --- ### 📝 Commits (5) - [`e1c5726`](https://github.com/microsoft/terminal/commit/e1c57265d95c7699d4c03d70482fce5794fda0f6) Use memcmp for TextAttribute & TextColor comparison - [`ae4382e`](https://github.com/microsoft/terminal/commit/ae4382e43d1368f0a26e0c3e8e1816c5e8288630) Missed one - [`e84eeae`](https://github.com/microsoft/terminal/commit/e84eeae396529e53d7acbc7148d77c2472907fa1) Nope, doesn't work - [`149e967`](https://github.com/microsoft/terminal/commit/149e967692dd3281f2b2450b86a220987fcf81ae) Merge branch 'main' into chesterliu/dev/text-colorrrr - [`5423de5`](https://github.com/microsoft/terminal/commit/5423de51ff3477164fd69e0167ccb9cac09f5f61) Merge branch 'main' into chesterliu/dev/text-colorrrr ### 📊 Changes **5 files changed** (+29 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/TextAttribute.cpp` (+2 -0) 📝 `src/buffer/out/TextAttribute.hpp` (+10 -21) 📝 `src/buffer/out/TextColor.cpp` (+7 -0) 📝 `src/buffer/out/TextColor.h` (+9 -15) 📝 `src/inc/conattrs.hpp` (+1 -1) </details> ### 📄 Description `TextAttribute` and `TextColor` are commonly used structures in hot paths. This commit replaces more complex comparisons where each field is compared independently with a single call to `memcmp`. This compiles down to just a few instructions. This reduces code and binary size and improves performance for paths were `TextAttribute`s need to be compared. ## PR Checklist * [x] Supports #10563 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed * termbench still works ✔️ Co-authored-by: Leonard Hecker <lhecker@microsoft.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?