starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10581] [MERGED] Introduce feature flag for editable actions page #28116

New Issue
Open
opened 2026-01-31 09:26:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:26:27 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10581
Author: @carlos-zamora
Created: 7/7/2021
Status: ✅ Merged
Merged: 7/8/2021
Merged by: @undefined

Base: main ← Head: dev/cazamor/actions-page/disable-edit-mode

📝 Commits (1)

  • 1f904c1 Introduce feature flag for editable actions page

📊 Changes

7 files changed (+406 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+16 -1)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+14 -1)
➕ src/cascadia/TerminalSettingsEditor/ReadOnlyActions.cpp (+64 -0)
➕ src/cascadia/TerminalSettingsEditor/ReadOnlyActions.h (+57 -0)
➕ src/cascadia/TerminalSettingsEditor/ReadOnlyActions.idl (+23 -0)
➕ src/cascadia/TerminalSettingsEditor/ReadOnlyActions.xaml (+225 -0)
📝 src/features.xml (+7 -0)

📄 Description

Summary of the Pull Request

Adds a feature flag Feature_EditableActionsPage that controls whether the Actions page in the Settings UI is read-only vs editable. The editable version is disabled for Release builds and enabled everywhere else (i.e. Dev, Preview, etc...).

Validated using <stage> AlwaysEnabled and AlwaysDisabled.

References

#6900 - Actions Page Epic

PR Checklist

Closes #10578

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10581 **Author:** [@carlos-zamora](https://github.com/carlos-zamora) **Created:** 7/7/2021 **Status:** ✅ Merged **Merged:** 7/8/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/cazamor/actions-page/disable-edit-mode` --- ### 📝 Commits (1) - [`1f904c1`](https://github.com/microsoft/terminal/commit/1f904c14ac9b8d383388fd13d8187946acc89e54) Introduce feature flag for editable actions page ### 📊 Changes **7 files changed** (+406 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+16 -1) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+14 -1) ➕ `src/cascadia/TerminalSettingsEditor/ReadOnlyActions.cpp` (+64 -0) ➕ `src/cascadia/TerminalSettingsEditor/ReadOnlyActions.h` (+57 -0) ➕ `src/cascadia/TerminalSettingsEditor/ReadOnlyActions.idl` (+23 -0) ➕ `src/cascadia/TerminalSettingsEditor/ReadOnlyActions.xaml` (+225 -0) 📝 `src/features.xml` (+7 -0) </details> ### 📄 Description ## Summary of the Pull Request Adds a feature flag `Feature_EditableActionsPage` that controls whether the Actions page in the Settings UI is read-only vs editable. The editable version is disabled for `Release` builds and enabled everywhere else (i.e. Dev, Preview, etc...). Validated using `<stage>` `AlwaysEnabled` and `AlwaysDisabled`. ## References #6900 - Actions Page Epic ## PR Checklist Closes #10578 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?