[PR #10569] [MERGED] Skip accessibility notifier and all event calculations when we're in PTY mode #28118

Open
opened 2026-01-31 09:26:27 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10569
Author: @miniksa
Created: 7/6/2021
Status: ✅ Merged
Merged: 7/9/2021
Merged by: @undefined

Base: main ← Head: dev/miniksa/acc_nooop


📝 Commits (3)

  • 13cfbac Add no-op notifier when we're in PTY mode #10568
  • 2a0367e Plan B. Explicitly create the notifier unless PTY. Check for null at all callsites and avoid parameter math if it's null to save more time.
  • 37a76e6 don't pass param to accessibility notifier creation

📊 Changes

12 files changed (+111 additions, -45 deletions)

View changed files

📝 src/host/CursorBlinker.cpp (+5 -4)
📝 src/host/_output.cpp (+13 -7)
📝 src/host/_stream.cpp (+4 -1)
📝 src/host/conimeinfo.cpp (+4 -1)
📝 src/host/getset.cpp (+8 -4)
📝 src/host/screenInfo.cpp (+26 -7)
📝 src/host/screenInfo.hpp (+1 -0)
📝 src/host/selection.cpp (+10 -2)
📝 src/host/srvinit.cpp (+11 -0)
📝 src/interactivity/base/ServiceLocator.cpp (+18 -17)
📝 src/interactivity/inc/ServiceLocator.hpp (+1 -0)
📝 src/server/IoDispatchers.cpp (+10 -2)

📄 Description

Change accessibility notifier creation so we do not create one when we're in PTY mode. (Guard all call sites to skip math/event work when the notifier is null.) MSAA events are legacy events that are registered for globally and used by some screen readers to find content in the conhost window. The PTY mode is not responsible for hosting the display content or input window, so it makes sense for it to not broadcast these events and delegate the accessibility requirement to the connected terminal.

References

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10569 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 7/6/2021 **Status:** ✅ Merged **Merged:** 7/9/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/miniksa/acc_nooop` --- ### 📝 Commits (3) - [`13cfbac`](https://github.com/microsoft/terminal/commit/13cfbac0cb667f3c88f8ee6ebcc77beeeb31deaf) Add no-op notifier when we're in PTY mode #10568 - [`2a0367e`](https://github.com/microsoft/terminal/commit/2a0367ec8ed0620821ffa6a7addab57e87306448) Plan B. Explicitly create the notifier unless PTY. Check for null at all callsites and avoid parameter math if it's null to save more time. - [`37a76e6`](https://github.com/microsoft/terminal/commit/37a76e6161cc053adcd736e673fbbab405478206) don't pass param to accessibility notifier creation ### 📊 Changes **12 files changed** (+111 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `src/host/CursorBlinker.cpp` (+5 -4) 📝 `src/host/_output.cpp` (+13 -7) 📝 `src/host/_stream.cpp` (+4 -1) 📝 `src/host/conimeinfo.cpp` (+4 -1) 📝 `src/host/getset.cpp` (+8 -4) 📝 `src/host/screenInfo.cpp` (+26 -7) 📝 `src/host/screenInfo.hpp` (+1 -0) 📝 `src/host/selection.cpp` (+10 -2) 📝 `src/host/srvinit.cpp` (+11 -0) 📝 `src/interactivity/base/ServiceLocator.cpp` (+18 -17) 📝 `src/interactivity/inc/ServiceLocator.hpp` (+1 -0) 📝 `src/server/IoDispatchers.cpp` (+10 -2) </details> ### 📄 Description Change accessibility notifier creation so we do not create one when we're in PTY mode. (Guard all call sites to skip math/event work when the notifier is null.) MSAA events are legacy events that are registered for globally and used by some screen readers to find content in the conhost window. The PTY mode is not responsible for hosting the display content or input window, so it makes sense for it to not broadcast these events and delegate the accessibility requirement to the connected terminal. ## References - #10537 ## PR Checklist * [x] Closes #10568 * [x] I work here * [x] Manual test launches passed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:27 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28118