[PR #10601] [MERGED] Fix all fragments not loading when one is badly formed #28124

Open
opened 2026-01-31 09:26:30 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10601
Author: @PankajBhojwani
Created: 7/9/2021
Status: ✅ Merged
Merged: 7/9/2021
Merged by: @undefined

Base: main ← Head: dev/pabhoj/fragment_fix


📝 Commits (1)

  • 43c25e8 fix fragments not loading

📊 Changes

1 file changed (+27 additions, -15 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+27 -15)

📄 Description

Adds try-catch blocks to the parts where we layer a fragment onto a profile and create a new profile from a fragment. This allows us to continue looping over the remaining fragments after failing to use a badly-formed one, instead of aborting prematurely.

PR Checklist

Validation Steps Performed

Non-badly formed fragments get loaded even if there is a badly formed one somewhere


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10601 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 7/9/2021 **Status:** ✅ Merged **Merged:** 7/9/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/fragment_fix` --- ### 📝 Commits (1) - [`43c25e8`](https://github.com/microsoft/terminal/commit/43c25e8282dd59cbb306926fc858f9b176eee0f8) fix fragments not loading ### 📊 Changes **1 file changed** (+27 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+27 -15) </details> ### 📄 Description Adds try-catch blocks to the parts where we layer a fragment onto a profile and create a new profile from a fragment. This allows us to continue looping over the remaining fragments after failing to use a badly-formed one, instead of aborting prematurely. ## PR Checklist * [x] Closes #10590 ## Validation Steps Performed Non-badly formed fragments get loaded even if there is a badly formed one somewhere --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28124