[PR #10593] [MERGED] Enable /Zc:preprocessor #28126

Open
opened 2026-01-31 09:26:30 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10593
Author: @lhecker
Created: 7/9/2021
Status: Merged
Merged: 7/14/2021
Merged by: @undefined

Base: mainHead: dev/lhecker/7539-key-bindings


📝 Commits (2)

📊 Changes

28 files changed (+337 additions, -628 deletions)

View changed files

📝 build/Helix/PrepareHelixPayload.ps1 (+4 -4)
📝 build/Helix/packages.config (+1 -1)
📝 build/packages.config (+1 -1)
📝 build/pipelines/templates/helix-createprojfile-steps.yml (+1 -1)
📝 build/pipelines/templates/helix-runtests-job.yml (+1 -2)
📝 src/buffer/out/TextAttribute.hpp (+1 -1)
📝 src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/Utils.h (+55 -49)
📝 src/cascadia/TerminalSettingsEditor/ViewModelHelpers.h (+3 -3)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+41 -34)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj (+4 -4)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters (+4 -1)
📝 src/cascadia/UnitTests_Remoting/RemotingTests.cpp (+122 -412)
📝 src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp (+1 -1)
📝 src/cascadia/UnitTests_TerminalCore/TerminalApiTest.cpp (+1 -1)
📝 src/cascadia/WindowsTerminal_UIATests/WindowsTerminal.UIA.Tests.csproj (+6 -6)
📝 src/cascadia/WindowsTerminal_UIATests/packages.config (+1 -1)
📝 src/cascadia/inc/cppwinrt_utils.h (+17 -17)
📝 src/common.build.tests.props (+2 -2)

...and 8 more files

📄 Description

This commit is a preparation for upcoming changes to KeyChordSerialization for #7539 and #10203.
In order to support variadic macros, /Zc:preprocessor was enabled, which required changing unrelated parts of the project.

PR Checklist

  • I work here
  • Tests added/passed

Validation Steps Performed

  • Project still compiles ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10593 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 7/9/2021 **Status:** ✅ Merged **Merged:** 7/14/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/7539-key-bindings` --- ### 📝 Commits (2) - [`9360050`](https://github.com/microsoft/terminal/commit/9360050a9e6bb4b0acbd14f409a85742a537f30b) Enable /Zc:preprocessor - [`9cff9e7`](https://github.com/microsoft/terminal/commit/9cff9e7b553169dd59c88c696398ab1f4ecc6ec8) Address reviewer comments ### 📊 Changes **28 files changed** (+337 additions, -628 deletions) <details> <summary>View changed files</summary> 📝 `build/Helix/PrepareHelixPayload.ps1` (+4 -4) 📝 `build/Helix/packages.config` (+1 -1) 📝 `build/packages.config` (+1 -1) 📝 `build/pipelines/templates/helix-createprojfile-steps.yml` (+1 -1) 📝 `build/pipelines/templates/helix-runtests-job.yml` (+1 -2) 📝 `src/buffer/out/TextAttribute.hpp` (+1 -1) 📝 `src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/Utils.h` (+55 -49) 📝 `src/cascadia/TerminalSettingsEditor/ViewModelHelpers.h` (+3 -3) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+41 -34) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj` (+4 -4) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters` (+4 -1) 📝 `src/cascadia/UnitTests_Remoting/RemotingTests.cpp` (+122 -412) 📝 `src/cascadia/UnitTests_TerminalCore/ScreenSizeLimitsTest.cpp` (+1 -1) 📝 `src/cascadia/UnitTests_TerminalCore/TerminalApiTest.cpp` (+1 -1) 📝 `src/cascadia/WindowsTerminal_UIATests/WindowsTerminal.UIA.Tests.csproj` (+6 -6) 📝 `src/cascadia/WindowsTerminal_UIATests/packages.config` (+1 -1) 📝 `src/cascadia/inc/cppwinrt_utils.h` (+17 -17) 📝 `src/common.build.tests.props` (+2 -2) _...and 8 more files_ </details> ### 📄 Description This commit is a preparation for upcoming changes to KeyChordSerialization for #7539 and #10203. In order to support variadic macros, /Zc:preprocessor was enabled, which required changing unrelated parts of the project. ## PR Checklist * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * Project still compiles ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28126